From: Sebastian Reichel <sre@kernel.org>
To: Ramakrishna Pallala <ramakrishna.pallala@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Krzysztof Kozlowski <k.kozlowski.k@gmail.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>
Subject: Re: [PATCH v1] power: max17042_battery: add HEALTH and TEMP_* properties support
Date: Sat, 23 May 2015 20:10:05 +0200 [thread overview]
Message-ID: <20150523181004.GC16004@earth> (raw)
In-Reply-To: <1430782832-16518-1-git-send-email-ramakrishna.pallala@intel.com>
[-- Attachment #1: Type: text/plain, Size: 791 bytes --]
Hi,
On Tue, May 05, 2015 at 05:10:32AM +0530, Ramakrishna Pallala wrote:
> This patch adds the support for following battery properties
> to max17042 fuel gauge driver.
>
> POWER_SUPPLY_PROP_TEMP_ALERT_MIN
> POWER_SUPPLY_PROP_TEMP_ALERT_MAX
> POWER_SUPPLY_PROP_TEMP_MIN
> POWER_SUPPLY_PROP_TEMP_MAX
> POWER_SUPPLY_PROP_HEALTH
>
> Signed-off-by: Ramakrishna Pallala <ramakrishna.pallala@intel.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
The patch does not work for me:
drivers/power/max17042_battery.c: In function ‘max17042_get_battery_health’:
drivers/power/max17042_battery.c:150:34: error: ‘MAX17042_VMAX_TOLERENCE’ undeclared (first use in this function)
if (vbatt > chip->pdata->vmax + MAX17042_VMAX_TOLERENCE) {
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-05-23 18:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 23:40 [PATCH v1] power: max17042_battery: add HEALTH and TEMP_* properties support Ramakrishna Pallala
2015-05-22 3:24 ` Pallala, Ramakrishna
2015-05-23 18:10 ` Sebastian Reichel [this message]
2015-05-23 19:28 ` Pallala, Ramakrishna
2015-05-23 19:28 ` Pallala, Ramakrishna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150523181004.GC16004@earth \
--to=sre@kernel.org \
--cc=k.kozlowski.k@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=ramakrishna.pallala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.