From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751557AbbEXSsa (ORCPT ); Sun, 24 May 2015 14:48:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54020 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751266AbbEXSs3 (ORCPT ); Sun, 24 May 2015 14:48:29 -0400 Date: Sun, 24 May 2015 20:47:46 +0200 From: Oleg Nesterov To: Shailendra Verma Cc: Roland McGrath , linux-kernel@vger.kernel.org Subject: Re: [PATCH] kernel:ptrace - Fix typo in comment in function __ptrace_unlink(). Message-ID: <20150524184746.GA18917@redhat.com> References: <1432357715-4236-1-git-send-email-shailendra.capricorn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432357715-4236-1-git-send-email-shailendra.capricorn@gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org So this "fix" is wrong. But you know, even if it was correct... IMO, the fixes like this can only make sense as a "while at it" part of the meaningful change. On 05/23, Shailendra Verma wrote: > > Signed-off-by: Shailendra Verma > --- > kernel/ptrace.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/ptrace.c b/kernel/ptrace.c > index c8e0e05..46249f9 100644 > --- a/kernel/ptrace.c > +++ b/kernel/ptrace.c > @@ -108,7 +108,7 @@ void __ptrace_unlink(struct task_struct *child) > > /* > * If transition to TASK_STOPPED is pending or in TASK_TRACED, kick > - * @child in the butt. Note that @resume should be used iff @child > + * @child in the butt. Note that @resume should be used if @child > * is in TASK_TRACED; otherwise, we might unduly disrupt > * TASK_KILLABLE sleeps. > */ > -- > 1.7.9.5 >