From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from youngberry.canonical.com ([91.189.89.112]:55066 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750813AbbEYMzU (ORCPT ); Mon, 25 May 2015 08:55:20 -0400 Date: Mon, 25 May 2015 13:55:17 +0100 From: Luis Henriques To: Ben Hutchings Cc: stable , "Martin K. Petersen" , Tejun Heo Subject: Re: [PATCH stable 1/2] libata: Update Crucial/Micron blacklist Message-ID: <20150525125517.GB1887@ares> References: <1432248698.12412.43.camel@decadent.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1432248698.12412.43.camel@decadent.org.uk> Sender: stable-owner@vger.kernel.org List-ID: On Thu, May 21, 2015 at 11:51:38PM +0100, Ben Hutchings wrote: > From: "Martin K. Petersen" > Date: Fri, 27 Mar 2015 15:17:20 -0400 > > commit ff7f53fb82a7801a778e5902bdbbc5e195ab0de0 upstream. > > Micron has released an updated firmware (MU02) for M510/M550/MX100 > drives to fix the issues with queued TRIM. Queued TRIM remains broken on > M500 but is working fine on later drives such as M600 and MX200. > > Tweak our blacklist to reflect the above. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=71371 > Signed-off-by: Martin K. Petersen > Signed-off-by: Tejun Heo > [bwh: Backported to 3.16: adjust context and drop ZERO_AFTER_TRIM flags] > Signed-off-by; Ben Hutchings > --- > This appears to be needed for 3.12-3.18 stable branches, although 3.12.y > already has the following patch and will therefore need further context > changes. > Thank you, Ben. I'll queue these 2 patches along with another backport of commit 9a9324d39696 ("libata: Blacklist queued TRIM on all Samsung 800-series"). Cheers, -- Lu�s > Ben. > > drivers/ata/libata-core.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > --- a/drivers/ata/libata-core.c > +++ b/drivers/ata/libata-core.c > @@ -4225,9 +4225,10 @@ static const struct ata_blacklist_entry > > /* devices that don't properly handle queued TRIM commands */ > { "Micron_M500*", NULL, ATA_HORKAGE_NO_NCQ_TRIM, }, > - { "Crucial_CT???M500SSD*", NULL, ATA_HORKAGE_NO_NCQ_TRIM, }, > - { "Micron_M550*", NULL, ATA_HORKAGE_NO_NCQ_TRIM, }, > - { "Crucial_CT*M550SSD*", NULL, ATA_HORKAGE_NO_NCQ_TRIM, }, > + { "Crucial_CT*M500*", NULL, ATA_HORKAGE_NO_NCQ_TRIM, }, > + { "Micron_M5[15]0*", "MU01", ATA_HORKAGE_NO_NCQ_TRIM, }, > + { "Crucial_CT*M550*", "MU01", ATA_HORKAGE_NO_NCQ_TRIM, }, > + { "Crucial_CT*MX100*", "MU01", ATA_HORKAGE_NO_NCQ_TRIM, }, > > /* > * Some WD SATA-I drives spin up and down erratically when the link > > -- > Ben Hutchings > I'm not a reverse psychological virus. Please don't copy me into your sig.