Re: [PATCH] init/do_mounts: Add create_dev() failure log

[Pavel Machek <pavel@ucw.cz>]

On Mon 2015-05-25 10:47:50, Vishnu Pratap Singh wrote:
> if create_dev() function fails to create the root mount device (/dev/root),
> then it goes to panic as root device not found but there is no check/log
> present in case of failure, So i have added the log in case it fails to create
> the root device. It will help in debugging.
> 
> Signed-off-by: Vishnu Pratap Singh <vishnu.ps@samsung.com>

Acked-by: Pavel Machek <pavel@ucw.cz>

> ---
>  init/do_mounts.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/init/do_mounts.c b/init/do_mounts.c
> index 8369ffa..a68aaf6 100644
> --- a/init/do_mounts.c
> +++ b/init/do_mounts.c
> @@ -532,7 +532,8 @@ void __init mount_root(void)
>  	}
>  #endif
>  #ifdef CONFIG_BLOCK
> -	create_dev("/dev/root", ROOT_DEV);
> +	if(create_dev("/dev/root", ROOT_DEV) < 0)
> +		printk(KERN_ERR "Failed to create %s device !!\n", "/dev/root");

But please make it "if (" and " !!" -> "!"

Thanks,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html