From: Dan Carpenter <dan.carpenter@oracle.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: tolga ceylan <tolga.ceylan@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Greg Donald <gdonald@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Benoit Taine <benoit.taine@lip6.fr>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] drivers: staging: rtl8192u: ieee80211: ieee80211_softmac.c: auth parse error code byte order fix
Date: Mon, 25 May 2015 19:31:18 +0300 [thread overview]
Message-ID: <20150525163118.GD11588@mwanda> (raw)
In-Reply-To: <5563406A.3010202@windriver.com>
Good advice. This was actually found by Sparse and the changelog should
say:
Sparse complains about this:
ieee80211_softmac.c:1561:16: warning: cast from restricted __le16
ieee80211_softmac.c:1561:16: warning: incorrect type in return expression (different base types)
ieee80211_softmac.c:1561:16: expected unsigned short
ieee80211_softmac.c:1561:16: got restricted __le16 [usertype] <noident>
The caller basically only cares about zero and non-zero so it doesn't
affect runtime (except for making an debug message more accurate).
regards,
dan carpenter
next prev parent reply other threads:[~2015-05-25 16:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 3:55 [PATCH 1/1] drivers: staging: rtl8192u: ieee80211: ieee80211_softmac.c: auth parse error code byte order fix Tolga Ceylan
2015-05-24 2:53 ` tolga ceylan
2015-05-24 8:13 ` Sudip Mukherjee
2015-05-25 15:31 ` Paul Gortmaker
2015-05-25 16:31 ` Dan Carpenter [this message]
2015-05-30 12:19 ` Tolga Ceylan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150525163118.GD11588@mwanda \
--to=dan.carpenter@oracle.com \
--cc=benoit.taine@lip6.fr \
--cc=cristina.opriceana@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gdonald@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hamohammed.sa@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mahfouz.saif.elyazal@gmail.com \
--cc=paul.gortmaker@windriver.com \
--cc=tolga.ceylan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.