From: David Gibson <david@gibson.dropbear.id.au>
To: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
mdroth@linux.vnet.ibm.com, qemu-ppc@nongnu.org,
qemu-devel@nongnu.org, agraf@suse.de
Subject: Re: [Qemu-devel] [PATCH v5 3/4] spapr_pci: enumerate and add PCI device tree
Date: Tue, 26 May 2015 10:34:26 +1000 [thread overview]
Message-ID: <20150526003426.GK6255@voom.redhat.com> (raw)
In-Reply-To: <871ti57y6f.fsf@abhimanyu.in.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1181 bytes --]
On Mon, May 25, 2015 at 03:53:52PM +0530, Nikunj A Dadhania wrote:
> Alexey Kardashevskiy <aik@ozlabs.ru> writes:
> > On 05/25/2015 02:45 PM, Nikunj A Dadhania wrote:
> >> Alexey Kardashevskiy <aik@ozlabs.ru> writes:
[snip]
> >>> Can we also add a hack here to scan for the "qemu,phb-enumerated" string in
> >>> the SLOF bin image?
> >>
> >> Really ? That would be ugly.
> >
> >
> > Well, chances that the binary image will have this line by accident are zero.
> >
> > And I spent quite some time debugging SRIOV + VFIO when I realized that
> > SLOF is old on the test machine where others used to debug too. It would be
> > really nice to have a warning that something is wrong. May be extend
> > "client-architecture-support" somehow or have some release/date signature
> > in known place in SLOF... Thomas (?) also asked for this :)
>
> Sure, I can work on this. I would not recommend grepping though.
Yeah, don't do this. The ugliness is not worth it.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-05-26 0:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 8:25 [Qemu-devel] [PATCH v5 0/4] spapr_pci: DT field fixes and PCI DT node creation in QEMU Nikunj A Dadhania
2015-05-19 8:25 ` [Qemu-devel] [PATCH v5 1/4] spapr_pci: encode missing 64-bit memory address space Nikunj A Dadhania
2015-05-19 8:26 ` [Qemu-devel] [PATCH v5 2/4] spapr_pci: encode class code including Prog IF register Nikunj A Dadhania
2015-05-19 8:26 ` [Qemu-devel] [PATCH v5 3/4] spapr_pci: enumerate and add PCI device tree Nikunj A Dadhania
2015-05-24 11:05 ` Alexey Kardashevskiy
2015-05-25 4:45 ` Nikunj A Dadhania
2015-05-25 9:51 ` Alexey Kardashevskiy
2015-05-25 10:23 ` Nikunj A Dadhania
2015-05-26 0:34 ` David Gibson [this message]
2015-05-19 8:26 ` [Qemu-devel] [PATCH v5 4/4] spapr_pci: populate ibm,loc-code Nikunj A Dadhania
2015-05-24 11:24 ` Alexey Kardashevskiy
2015-05-25 4:58 ` Nikunj A Dadhania
2015-05-25 10:06 ` Alexey Kardashevskiy
2015-05-25 10:27 ` Nikunj A Dadhania
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150526003426.GK6255@voom.redhat.com \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=mdroth@linux.vnet.ibm.com \
--cc=nikunj@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.