All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Josef Bacik <jbacik@fb.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] generic: add fiemap test that does prealloc
Date: Tue, 26 May 2015 11:31:30 +1000	[thread overview]
Message-ID: <20150526013130.GX4316@dastard> (raw)
In-Reply-To: <1432055622-8638-1-git-send-email-jbacik@fb.com>

On Tue, May 19, 2015 at 01:13:42PM -0400, Josef Bacik wrote:
> I noticed that btrfs wasn't setting unwritten on prealloc test, and then
> subsequently noticed that we weren't testing fiemap on prealloc extents with the
> fiemap-tester.  This patch adds another test that does the same as generic/225
> only with prealloc enabled.  Thanks,

Fails on XFS, but that's because XFS is doing things fiemap-tester
does not understand (speculative prealloc beyond EOF when appending
writes occur on files larger than 64k) and hence XFS ends up with
zeroed data on disk in places where fiemaptester is expecting
preallocated blocks.

i.e. there's not data corruption, and nothing wrong with XFS's
behaioviour, just a broken assumption that the filesystem will lay
out data due to buffered writes and delayed allocation exactly as it
expects.

IOWs, i think that fiemap-tester might need to direct IO to get the
results it expects, not buffered IO...

> +_scratch_mount > /dev/null 2>&1
> +
> +rm -f $seqres.full
> +fiemapfile=$SCRATCH_MNT/$seq.fiemap
> +fiemaplog=$SCRATCH_MNT/$seq.log

The log file to use for debug information is $seqres.full.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

  reply	other threads:[~2015-05-26  1:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-19 17:13 [PATCH] generic: add fiemap test that does prealloc Josef Bacik
2015-05-26  1:31 ` Dave Chinner [this message]
2015-05-26 13:58   ` Josef Bacik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150526013130.GX4316@dastard \
    --to=david@fromorbit.com \
    --cc=fstests@vger.kernel.org \
    --cc=jbacik@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.