From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eddie Kovsky Subject: [PATCH] Fix reversed logic in drivers/md/md.c Date: Mon, 25 May 2015 22:36:24 -0600 Message-ID: <20150526043624.GA24890@athena> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline Sender: linux-raid-owner@vger.kernel.org To: neilb@suse.de Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-raid.ids =46ixes the following compiler warning in next-20150525 using gcc 5.1.0= : drivers/md/md.c: In function =E2=80=98update_array_info=E2=80=99: drivers/md/md.c:6394:26: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses] !mddev->persistent !=3D info->not_persistent|| Signed-off-by: Eddie Kovsky --- drivers/md/md.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/md.c b/drivers/md/md.c index eb27b2a74492..b0f98b5b8985 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -6391,7 +6391,7 @@ static int update_array_info(struct mddev *mddev,= mdu_array_info_t *info) mddev->ctime !=3D info->ctime || mddev->level !=3D info->level || /* mddev->layout !=3D info->layout || */ - !mddev->persistent !=3D info->not_persistent|| + mddev->persistent =3D=3D info->not_persistent|| mddev->chunk_sectors !=3D info->chunk_size >> 9 || /* ignore bottom 8 bits of state, and allow SB_BITMAP_PRESENT to = change */ ((state^info->state) & 0xfffffe00) --=20 2.4.1 -- To unsubscribe from this list: send the line "unsubscribe linux-raid" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751464AbbEZFDI (ORCPT ); Tue, 26 May 2015 01:03:08 -0400 Received: from gproxy8-pub.mail.unifiedlayer.com ([67.222.33.93]:35444 "HELO gproxy8-pub.mail.unifiedlayer.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751181AbbEZFDG (ORCPT ); Tue, 26 May 2015 01:03:06 -0400 X-Greylist: delayed 1162 seconds by postgrey-1.27 at vger.kernel.org; Tue, 26 May 2015 01:03:06 EDT X-Authority-Analysis: v=2.1 cv=Zox+dbLG c=1 sm=1 tr=0 a=PkLafpyMt2xwRD+PMJrZ3Q==:117 a=PkLafpyMt2xwRD+PMJrZ3Q==:17 a=cNaOj0WVAAAA:8 a=f5113yIGAAAA:8 a=J0QyKEt1u0cA:10 a=IkcTkHD0fZMA:10 a=ptNznvi-AAAA:8 a=fztpppUj2ZoA:10 a=Xwexni91U_8A:10 a=h1PgugrvaO0A:10 a=anUTD3Gly_8trQ4g564A:9 a=QEXdDO2ut3YA:10 Date: Mon, 25 May 2015 22:36:24 -0600 From: Eddie Kovsky To: neilb@suse.de Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] Fix reversed logic in drivers/md/md.c Message-ID: <20150526043624.GA24890@athena> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.5.23 (2014-03-12) X-Identified-User: {1650:box492.bluehost.com:edkovsky:edkovsky.org} {sentby:smtp auth 65.102.196.57 authed with ewk+edkovsky.org} Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following compiler warning in next-20150525 using gcc 5.1.0: drivers/md/md.c: In function ‘update_array_info’: drivers/md/md.c:6394:26: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses] !mddev->persistent != info->not_persistent|| Signed-off-by: Eddie Kovsky --- drivers/md/md.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/md.c b/drivers/md/md.c index eb27b2a74492..b0f98b5b8985 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -6391,7 +6391,7 @@ static int update_array_info(struct mddev *mddev, mdu_array_info_t *info) mddev->ctime != info->ctime || mddev->level != info->level || /* mddev->layout != info->layout || */ - !mddev->persistent != info->not_persistent|| + mddev->persistent == info->not_persistent|| mddev->chunk_sectors != info->chunk_size >> 9 || /* ignore bottom 8 bits of state, and allow SB_BITMAP_PRESENT to change */ ((state^info->state) & 0xfffffe00) -- 2.4.1