All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Bernhard Thaler <bernhard.thaler@wvnet.at>
Cc: netfilter-devel@vger.kernel.org, davej@codemonkey.org.uk,
	Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: ebtables not working correctly with 1086bbe97a074844188c6c988fa0b1a98c3ccbb9
Date: Tue, 26 May 2015 10:14:14 +0200	[thread overview]
Message-ID: <20150526081414.GA7817@breakpoint.cc> (raw)
In-Reply-To: <5563D5E5.70502@wvnet.at>

Bernhard Thaler <bernhard.thaler@wvnet.at> wrote:
> setting rules with ebtables does not work for me any more with
> 1086bbe97a074844188c6c988fa0b1a98c3ccbb9 / "netfilter: ensure number of
> counters is >0 in do_replace()" in place.
> 
> There is an error message and no rules set in the end.
> 
> e.g.
> 
> root@kali:~# ebtables -t nat -A POSTROUTING --src 12:34:56:78:9a:bc -j DROP
> Unable to update the kernel. Two possible causes:
> 1. Multiple ebtables programs were executing simultaneously. The ebtables
>    userspace tool doesn't by default support multiple ebtables programs
> running

[..]

> With 1086bbe97a074844188c6c988fa0b1a98c3ccbb9 reverted everything works
> fine again.

Yes, seems we don't want the ebtables part of that commit.
The vmalloc() calls are conditional on repl->num_counters in ebtables,
and no counters are fetched on zero.

Would you mind submitting a partial revert patch?

Thanks for debugging this!

      reply	other threads:[~2015-05-26  8:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-26  2:09 ebtables not working correctly with 1086bbe97a074844188c6c988fa0b1a98c3ccbb9 Bernhard Thaler
2015-05-26  8:14 ` Florian Westphal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150526081414.GA7817@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=bernhard.thaler@wvnet.at \
    --cc=davej@codemonkey.org.uk \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.