From: Dan Carpenter <dan.carpenter@oracle.com>
To: o-takashi@sakamocchi.jp
Cc: alsa-devel@alsa-project.org
Subject: Re: ALSA: firewire-lib: pass the number of data blocks in incoming packets to outgoing packets
Date: Tue, 26 May 2015 11:49:24 +0300 [thread overview]
Message-ID: <20150526084924.GA25178@mwanda> (raw)
Hello Takashi Sakamoto,
The patch 6fc6b9ce41c6: "ALSA: firewire-lib: pass the number of data
blocks in incoming packets to outgoing packets" from May 22, 2015,
leads to the following static checker warning:
sound/firewire/amdtp.c:857 in_stream_callback()
warn: unsigned 'data_blocks' is never less than zero.
sound/firewire/amdtp.c
855
856 data_blocks = handle_in_packet(s, payload_quadlets, buffer);
857 if (data_blocks < 0) {
^^^^^^^^^^^^^^^
Never true. But handle_in_packet() does return negative error codes.
858 s->packet_index = -1;
859 break;
860 }
861
regards,
dan carpenter
next reply other threads:[~2015-05-26 8:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 8:49 Dan Carpenter [this message]
2015-05-26 14:46 ` ALSA: firewire-lib: pass the number of data blocks in incoming packets to outgoing packets Takashi Sakamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150526084924.GA25178@mwanda \
--to=dan.carpenter@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=o-takashi@sakamocchi.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.