From: Dan Carpenter <dan.carpenter@oracle.com>
To: laurentiu.palcu@intel.com
Cc: linux-pm@vger.kernel.org
Subject: re: power_supply: Add support for TI BQ25890 charger chip
Date: Tue, 26 May 2015 12:04:41 +0300 [thread overview]
Message-ID: <20150526090441.GA18601@mwanda> (raw)
Hello Laurentiu Palcu,
The patch 4aeae9cb0dad: "power_supply: Add support for TI BQ25890
charger chip" from May 19, 2015, leads to the following static
checker warning:
drivers/power/bq25890_charger.c:843 bq25890_probe()
warn: impossible condition '(bq->chip_id < 0) => (0-255 < 0)'
drivers/power/bq25890_charger.c
841
842 bq->chip_id = bq25890_field_read(bq, F_PN);
843 if (bq->chip_id < 0) {
^^^^^^^^^^^^^^^
Never true.
844 dev_err(dev, "Cannot read chip ID.\n");
845 return ret;
846 }
847
regards,
dan carpenter
next reply other threads:[~2015-05-26 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 9:04 Dan Carpenter [this message]
[not found] ` <CAD03FC+H0JQUR32eGLrVWe_OaiiMTxUmCxdBwuWnPwMRz8XSOQ@mail.gmail.com>
2015-05-26 20:32 ` power_supply: Add support for TI BQ25890 charger chip Sebastian Reichel
2015-05-27 9:27 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150526090441.GA18601@mwanda \
--to=dan.carpenter@oracle.com \
--cc=laurentiu.palcu@intel.com \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.