From: Kalle Valo <kvalo@codeaurora.org>
To: Okash Khawaja <okash.khawaja@gmail.com>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [v2, 1/2] adm8211: fix checkpatch errors for indentation and new line
Date: Tue, 26 May 2015 10:48:02 +0000 (UTC) [thread overview]
Message-ID: <20150526104802.E5F631416A0@smtp.codeaurora.org> (raw)
In-Reply-To: <20150511115325.GA5092@bytefire-computer>
> This patch fixes these checkpatch.pl errors around a single switch-case
> block:
>
> ERROR: switch and case should be at the same indent
> ERROR: trailing statements should be on next line
>
> More specifically, the fix has been applied to the five occurances of
> the errors listed below.
>
> ERROR: switch and case should be at the same indent
> #1100: FILE: adm8211.c:1100:
> + switch (cline) {
> [...]
> + default: reg |= (0x0 << 14);
>
> ERROR: trailing statements should be on next line
> #1101: FILE: adm8211.c:1101:
> + case 0x8: reg |= (0x1 << 14);
>
> ERROR: trailing statements should be on next line
> #1103: FILE: adm8211.c:1103:
> + case 0x16: reg |= (0x2 << 14);
>
> ERROR: trailing statements should be on next line
> #1105: FILE: adm8211.c:1105:
> + case 0x32: reg |= (0x3 << 14);
>
> ERROR: trailing statements should be on next line
> #1107: FILE: adm8211.c:1107:
> + default: reg |= (0x0 << 14);
>
>
> Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>
Thanks, 2 patches applied to wireless-drivers-next.git:
f5c65f38912e adm8211: fix checkpatch errors for indentation and new line
fe0a483ecf44 adm8211: fixed the possible pci cache line sizes inside switch-case
Kalle Valo
next prev parent reply other threads:[~2015-05-26 13:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 11:41 [PATCH v2 0/2] adm8211 patches Okash Khawaja
2015-05-11 11:53 ` [PATCH v2 1/2] adm8211: fix checkpatch errors for indentation and new line Okash Khawaja
2015-05-26 10:48 ` Kalle Valo [this message]
2015-05-11 11:58 ` [PATCH v2 2/2] adm8211: fixed the possible pci cache line sizes inside switch-case Okash Khawaja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150526104802.E5F631416A0@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=okash.khawaja@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.