From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Piotr S. Staszewski" <p.staszewski@gmail.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
devel@driverdev.osuosl.org, linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Subject: Re: [PATCH] staging: media: omap4iss: Reformat overly long lines
Date: Tue, 26 May 2015 07:15:24 -0700 [thread overview]
Message-ID: <20150526141524.GD21573@kroah.com> (raw)
In-Reply-To: <20150526085418.GA22775@swordfish>
On Tue, May 26, 2015 at 10:54:18AM +0200, Piotr S. Staszewski wrote:
> This reformats lines that were previously above 80 characters long,
> improving readability and making checkpatch.pl happy.
>
> Signed-off-by: Piotr S. Staszewski <p.staszewski@gmail.com>
> ---
> drivers/staging/media/omap4iss/iss_csi2.c | 21 ++++++++++++-------
> drivers/staging/media/omap4iss/iss_ipipe.c | 30 ++++++++++++++++++----------
> drivers/staging/media/omap4iss/iss_ipipeif.c | 10 ++++++----
> drivers/staging/media/omap4iss/iss_resizer.c | 8 +++++---
> 4 files changed, 44 insertions(+), 25 deletions(-)
>
> diff --git a/drivers/staging/media/omap4iss/iss_csi2.c b/drivers/staging/media/omap4iss/iss_csi2.c
> index d7ff769..a8714bb 100644
> --- a/drivers/staging/media/omap4iss/iss_csi2.c
> +++ b/drivers/staging/media/omap4iss/iss_csi2.c
> @@ -224,7 +224,8 @@ static u16 csi2_ctx_map_format(struct iss_csi2_device *csi2)
> fmtidx = 3;
> break;
> default:
> - WARN(1, KERN_ERR "CSI2: pixel format %08x unsupported!\n",
> + WARN(1,
> + KERN_ERR "CSI2: pixel format %08x unsupported!\n",
That line wasn't over 80 characters long, why change it?
greg k-h
next prev parent reply other threads:[~2015-05-26 14:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 8:54 [PATCH] staging: media: omap4iss: Reformat overly long lines Piotr S. Staszewski
2015-05-26 14:15 ` Greg Kroah-Hartman [this message]
2015-05-26 14:48 ` Piotr Staszewski
2015-05-26 15:02 ` [PATCH v2] " Piotr S. Staszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150526141524.GD21573@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=p.staszewski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.