From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755542AbbEZQAS (ORCPT ); Tue, 26 May 2015 12:00:18 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:36272 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932690AbbEZQAO (ORCPT ); Tue, 26 May 2015 12:00:14 -0400 Date: Tue, 26 May 2015 18:59:53 +0300 From: Dan Carpenter To: Jaime Arrocha Cc: gregkh@linuxfoundation.org, jonathankim@gctsemi.com, deanahn@gctsemi.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: gdm724x: Remove test for host endian Message-ID: <20150526155953.GK11588@mwanda> References: <20150526152944.GA23178@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150526152944.GA23178@localhost.localdomain> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 26, 2015 at 10:29:44AM -0500, Jaime Arrocha wrote: > This is the first patch of two. Both patches perform a small clean up > done to the section for host endian test. Instead of handling endianness > internally, kernel functions were added for use. > The second patch depends on the first one, it is just a small piece > that is no longer needed. This kind of dependencies are built in the the name patch 1/2 and 2/2. We don't want this kind of meta commentary in the permanent changelog. If it were needed then it would go under the --- cut off line. And anyway, fold patch 1 & 2 together into one patch. Do "one thing" per patch instead of half a thing per patch. > > Signed-off-by: Jaime Arrocha > --- <--- meta commentary goes here. > drivers/staging/gdm724x/gdm_endian.c | 52 +++++++++++++++------------------- > 1 file changed, 23 insertions(+), 29 deletions(-) > > diff --git a/drivers/staging/gdm724x/gdm_endian.c b/drivers/staging/gdm724x/gdm_endian.c > index f6cc90a..609a433 100644 > --- a/drivers/staging/gdm724x/gdm_endian.c > +++ b/drivers/staging/gdm724x/gdm_endian.c > @@ -11,57 +11,51 @@ > * GNU General Public License for more details. > */ > > -#include Is this related to endianness? > +#include > +#ifdef __LITTLE_ENDIAN > +#include > +#else > +#include > +#endif Why do we need this? Also the spacing is wrong. > u16 gdm_cpu_to_dev16(struct gdm_endian *ed, u16 x) > { > - if (ed->dev_ed == ed->host_ed) > - return x; > - > - return Endian16_Swap(x); > + if (ed->dev_ed == ENDIANNESS_LITTLE) > + return __cpu_to_le16(x); > + else > + return __cpu_to_be16(x); Use cpu_to_le16() no underscore versions everywhere. The other is for code which is shared with usespace. regards, dan carpenter