From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55284) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxN3U-0000vx-MA for qemu-devel@nongnu.org; Tue, 26 May 2015 18:10:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxN3T-0001mP-5V for qemu-devel@nongnu.org; Tue, 26 May 2015 18:10:36 -0400 Received: from hall.aurel32.net ([2001:bc8:30d7:101::1]:51828) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxN3S-0001kX-Jx for qemu-devel@nongnu.org; Tue, 26 May 2015 18:10:34 -0400 Date: Wed, 27 May 2015 00:10:32 +0200 From: Aurelien Jarno Message-ID: <20150526221032.GC12677@aurel32.net> References: <1432631384-470-1-git-send-email-aurelien@aurel32.net> <55649C14.1050207@twiddle.net> <5564E91D.1050504@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5564E91D.1050504@suse.de> Subject: Re: [Qemu-devel] [PATCH v2] target-s390x: fix LOAD MULTIPLE instruction on page boundary List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-devel@nongnu.org, Richard Henderson On 2015-05-26 23:43, Alexander Graf wrote: > > > On 26.05.15 18:15, Richard Henderson wrote: > > On 05/26/2015 02:09 AM, Aurelien Jarno wrote: > >> This is an important detail in case the base register is in the list > >> of registers to be loaded. If a page fault occurs this register might be > >> overwritten and when the instruction is later restarted the wrong > >> base register value is useD. > >> > >> Fix this by first loading the first and last value from memory, hence > >> triggering all possible page faults, and then the remaining registers. > >> > >> This fixes random segmentation faults seen in the guest. > >> > >> Cc: Alexander Graf > >> Cc: Richard Henderson > >> Signed-off-by: Aurelien Jarno > >> --- > >> target-s390x/translate.c | 128 ++++++++++++++++++++++++++++++++++++----------- > >> 1 file changed, 99 insertions(+), 29 deletions(-) > >> > >> Changes v1->v2: > >> - Do the load in two steps: first and last registers, and then the remaining ones > > > > Reviewed-by: Richard Henderson > > Thanks, applied to s390-next. > > So what do we do about the other patch set? For the other patch set, it seems the best to ignore the STFL/STFLE part. Patches 01 to 05 and 09 to 10 are still valid, they are just a collection of bug fixes and improvement not specially linked together. -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net