From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752370AbbE0ChH (ORCPT ); Tue, 26 May 2015 22:37:07 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:36309 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751220AbbE0ChD (ORCPT ); Tue, 26 May 2015 22:37:03 -0400 Date: Tue, 26 May 2015 19:37:02 -0700 From: Greg Kroah-Hartman To: Lu Baolu Cc: Heikki Krogerus , balbi@ti.com, David Cohen , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, qiuxu.zhuo@intel.com Subject: Re: [PATCH v4 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall Message-ID: <20150527023702.GA7038@kroah.com> References: <1432691137-2635-1-git-send-email-baolu.lu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432691137-2635-1-git-send-email-baolu.lu@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 27, 2015 at 09:45:37AM +0800, Lu Baolu wrote: > Phy drivers and the ulpi interface providers depend on the > registration of the ulpi bus. Ulpi registers the bus in > module_init(). This could cause unnecessary probe delays. What do you mean by "probe delays"? > > Reported-by: Zhuo Qiuxu > Signed-off-by: Lu Baolu > Acked-by: Heikki Krogerus > --- > drivers/usb/common/ulpi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c > index 0e6f968..01c0c04 100644 > --- a/drivers/usb/common/ulpi.c > +++ b/drivers/usb/common/ulpi.c > @@ -242,7 +242,7 @@ static int __init ulpi_init(void) > { > return bus_register(&ulpi_bus); > } > -module_init(ulpi_init); > +subsys_initcall(ulpi_init); Hasn't this already been rejected? confused, greg k-h