From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753011AbbE0Oxx (ORCPT ); Wed, 27 May 2015 10:53:53 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:48650 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751826AbbE0Oxv (ORCPT ); Wed, 27 May 2015 10:53:51 -0400 Date: Wed, 27 May 2015 07:53:30 -0700 From: Greg Kroah-Hartman To: Marcus Folkesson Cc: Oleg Drokin , Andreas Dilger , Greg Donald , Julia Lawall , Daniel Baluta , Lai Siyao , Andriy Skulysh , Joe Perches , HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: lustre: fix non-static symbol warnings reported by sparse Message-ID: <20150527145330.GA354@kroah.com> References: <1432738076-17240-1-git-send-email-marcus.folkesson@gmail.com> <1432738076-17240-2-git-send-email-marcus.folkesson@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432738076-17240-2-git-send-email-marcus.folkesson@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 27, 2015 at 04:47:56PM +0200, Marcus Folkesson wrote: > Warnings reported by sparse: > > drivers/staging/lustre/lustre/ptlrpc/pinger.c:94:5: > warning: symbol 'ptlrpc_ping' was not declared. Should it be static? > > drivers/staging/lustre/lustre/ptlrpc/pinger.c:113:6: > warning: symbol 'ptlrpc_update_next_ping' was not declared. Should it be static > > drivers/staging/lustre/lustre/ptlrpc/pinger.c:144:6: > warning: symbol 'pinger_check_timeout' was not declared. Should it be static? > > drivers/staging/lustre/lustre/ptlrpc/pinger.c:425:21: > warning: symbol 'ptlrpc_new_timeout' was not declared. Should it be static? > > drivers/staging/lustre/lustre/ptlrpc/pinger.c:551:1: > warning: symbol 'pet_list' was not declared. Should it be static? > > Signed-off-by: Marcus Folkesson > --- > drivers/staging/lustre/lustre/ptlrpc/pinger.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) What changed in v2 needs to go here, below the --- line, not in a separate email that will get lost, especially as it has a very odd subject line :( Please fix up and resend. thanks, greg k-h