From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752751AbbE0PAN (ORCPT ); Wed, 27 May 2015 11:00:13 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:49411 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751307AbbE0PAK (ORCPT ); Wed, 27 May 2015 11:00:10 -0400 Date: Wed, 27 May 2015 08:00:05 -0700 From: Greg KH To: Abhishek Bist Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] USB: hcd.h : Removed an unnecessary function prototype usb_find_interface_driver() Message-ID: <20150527150005.GA888@kroah.com> References: <1432734555-6797-1-git-send-email-ishubist@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432734555-6797-1-git-send-email-ishubist@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 27, 2015 at 07:19:15PM +0530, Abhishek Bist wrote: > This function is used to call before 2.6.x version of linux kernel but since then I haven't seen it's relative usage and it's not > being used any where right now after checking it through linux.crossrefrence.So, IMHO it would be relevant to remove this obselete > function from kernel mainline. Please properly wrap your changelog lines at 72 columns. > Signed-off-by: Abhishek Bist > --- > include/linux/usb/hcd.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h > index 68b1e83..c9aa779 100644 > --- a/include/linux/usb/hcd.h > +++ b/include/linux/usb/hcd.h > @@ -622,8 +622,6 @@ extern struct list_head usb_bus_list; > extern struct mutex usb_bus_list_lock; > extern wait_queue_head_t usb_kill_urb_queue; > > -extern int usb_find_interface_driver(struct usb_device *dev, > - struct usb_interface *interface); Good catch, care to fix up the wording in your changelog and resend this? thanks, greg k-h