From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.free-electrons.com (down.free-electrons.com. [37.187.137.238]) by gmr-mx.google.com with ESMTP id t6si746381wiz.0.2015.05.27.11.53.53 for ; Wed, 27 May 2015 11:53:53 -0700 (PDT) Date: Wed, 27 May 2015 20:53:52 +0200 From: Alexandre Belloni To: Jan Kardell Cc: Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Vincent Donnefort , Dan Carpenter , oen@telliq.com Subject: [rtc-linux] Re: [PATCH v2] rtc: pcf8563 fix: return -EINVAL if we read an invalid time. Message-ID: <20150527185352.GJ2185@piout.net> References: <1432730896-13423-1-git-send-email-jan.kardell@telliq.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <1432730896-13423-1-git-send-email-jan.kardell@telliq.com> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Hi, On 27/05/2015 at 14:48:16 +0200, Jan Kardell wrote : > @@ -204,6 +204,7 @@ static int pcf8563_get_datetime(struct i2c_client *client, struct rtc_time *tm) > pcf8563->voltage_low = 1; > dev_info(&client->dev, Aren't dev_err or dev_warn more appropriate? You used dev_err in your first patch, what made you change your mind? > "low voltage detected, date/time is not reliable.\n"); > + return -EINVAL; > } > > dev_dbg(&client->dev, -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752084AbbE0Sx4 (ORCPT ); Wed, 27 May 2015 14:53:56 -0400 Received: from down.free-electrons.com ([37.187.137.238]:41770 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751319AbbE0Sxy (ORCPT ); Wed, 27 May 2015 14:53:54 -0400 Date: Wed, 27 May 2015 20:53:52 +0200 From: Alexandre Belloni To: Jan Kardell Cc: Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Vincent Donnefort , Dan Carpenter , oen@telliq.com Subject: Re: [PATCH v2] rtc: pcf8563 fix: return -EINVAL if we read an invalid time. Message-ID: <20150527185352.GJ2185@piout.net> References: <1432730896-13423-1-git-send-email-jan.kardell@telliq.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432730896-13423-1-git-send-email-jan.kardell@telliq.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 27/05/2015 at 14:48:16 +0200, Jan Kardell wrote : > @@ -204,6 +204,7 @@ static int pcf8563_get_datetime(struct i2c_client *client, struct rtc_time *tm) > pcf8563->voltage_low = 1; > dev_info(&client->dev, Aren't dev_err or dev_warn more appropriate? You used dev_err in your first patch, what made you change your mind? > "low voltage detected, date/time is not reliable.\n"); > + return -EINVAL; > } > > dev_dbg(&client->dev, -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com