From: Jeff King <peff@peff.net>
To: "SZEDER Gábor" <szeder@ira.uka.de>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 1/2] config: add options to list only variable names
Date: Wed, 27 May 2015 17:08:26 -0400 [thread overview]
Message-ID: <20150527210826.GD22815@peff.net> (raw)
In-Reply-To: <20150527210438.GB22815@peff.net>
On Wed, May 27, 2015 at 05:04:38PM -0400, Jeff King wrote:
> > -'git config' [<file-option>] [-z|--null] -l | --list
> > +'git config' [<file-option>] [-z|--null] -l | --list | --list-name
>
> s/list-name/&s/, to match the code (and your commit message).
Doh, just saw your "1.5".
FWIW, I expected "PATCH 1.5/2" to be "eh, I should have put this in
between patches 1 and 2". I expect a re-roll to be "v1.5" (or just
"v2").
This was the only real error in the patch, so your 1.5 looks OK to me.
Though I hope you will consider my other suggestions, too.
-Peff
next prev parent reply other threads:[~2015-05-27 21:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 20:07 [PATCH 1/2] config: add options to list only variable names SZEDER Gábor
2015-05-27 20:07 ` [PATCH 2/2] completion: use new 'git config' options to reliably list " SZEDER Gábor
2015-05-27 20:11 ` [PATCH 1.5/2] config: add options to list only " SZEDER Gábor
2015-05-28 12:06 ` Christian Couder
2015-05-27 21:05 ` [PATCH 2/2] completion: use new 'git config' options to reliably list " Jeff King
2015-05-27 21:04 ` [PATCH 1/2] config: add options to list only " Jeff King
2015-05-27 21:08 ` Jeff King [this message]
2015-05-27 21:34 ` SZEDER Gábor
2015-05-27 22:20 ` Junio C Hamano
2015-05-28 12:29 ` [PATCH v2 0/2] config: list only variable names for completion SZEDER Gábor
2015-05-28 12:29 ` [PATCH v2 1/2] config: add options to list only variable names SZEDER Gábor
2015-05-28 19:20 ` Junio C Hamano
2015-05-28 19:36 ` Junio C Hamano
2015-05-29 11:34 ` Christian Couder
2015-05-29 11:39 ` Jeff King
2015-05-28 12:29 ` [PATCH v2 2/2] completion: use new 'git config' options to reliably list " SZEDER Gábor
2015-05-28 20:39 ` [PATCH v2 0/2] config: list only variable names for completion Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150527210826.GD22815@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.