All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>
Cc: Thomas Huth <thuth@redhat.com>,
	kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
	linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v6 8/8] macvtap/tun: cross-endian support for little-endian hosts
Date: Thu, 28 May 2015 14:59:38 +1000	[thread overview]
Message-ID: <20150528045938.GI6681@voom.redhat.com> (raw)
In-Reply-To: <20150424122732.19156.77709.stgit@bahia.local>


[-- Attachment #1.1: Type: text/plain, Size: 935 bytes --]

On Fri, Apr 24, 2015 at 02:50:36PM +0200, Greg Kurz wrote:
> The VNET_LE flag was introduced to fix accesses to virtio 1.0 headers
> that are always little-endian. It can also be used to handle the special
> case of a legacy little-endian device implemented by a big-endian host.
> 
> Let's add a flag and ioctls for big-endian devices as well. If both flags
> are set, little-endian wins.
> 
> Since this is isn't a common usecase, the feature is controlled by a kernel
> config option (not set by default).
> 
> Both macvtap and tun are covered by this patch since they share the same
> API with userland.
> 
> Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 183 bytes --]

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

WARNING: multiple messages have this Message-ID (diff)
From: David Gibson <david@gibson.dropbear.id.au>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Thomas Huth <thuth@redhat.com>,
	kvm@vger.kernel.org, linux-api@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	Cornelia Huck <cornelia.huck@de.ibm.com>
Subject: Re: [PATCH v6 8/8] macvtap/tun: cross-endian support for little-endian hosts
Date: Thu, 28 May 2015 14:59:38 +1000	[thread overview]
Message-ID: <20150528045938.GI6681@voom.redhat.com> (raw)
In-Reply-To: <20150424122732.19156.77709.stgit@bahia.local>

[-- Attachment #1: Type: text/plain, Size: 935 bytes --]

On Fri, Apr 24, 2015 at 02:50:36PM +0200, Greg Kurz wrote:
> The VNET_LE flag was introduced to fix accesses to virtio 1.0 headers
> that are always little-endian. It can also be used to handle the special
> case of a legacy little-endian device implemented by a big-endian host.
> 
> Let's add a flag and ioctls for big-endian devices as well. If both flags
> are set, little-endian wins.
> 
> Since this is isn't a common usecase, the feature is controlled by a kernel
> config option (not set by default).
> 
> Both macvtap and tun are covered by this patch since they share the same
> API with userland.
> 
> Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-05-28  4:59 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-24 12:24 [PATCH v6 0/8] vhost: support for cross endian guests Greg Kurz
2015-04-24 12:24 ` Greg Kurz
2015-04-24 12:24 ` [PATCH v6 1/8] virtio: introduce virtio_is_little_endian() helper Greg Kurz
2015-04-24 12:24   ` Greg Kurz
2015-04-27  9:07   ` Cornelia Huck
2015-04-27  9:07     ` Cornelia Huck
2015-05-28  4:57   ` David Gibson
     [not found]   ` <20150424122423.19156.34555.stgit-GiB8zCg7hOfDOqzlkpFKJg@public.gmane.org>
2015-05-28  4:57     ` David Gibson
2015-05-28  4:57       ` David Gibson
2015-04-24 12:24 ` [PATCH v6 2/8] tun: add tun_is_little_endian() helper Greg Kurz
2015-04-24 12:24   ` Greg Kurz
2015-04-27  9:08   ` Cornelia Huck
2015-04-27  9:08     ` Cornelia Huck
     [not found]   ` <20150424122435.19156.18985.stgit-GiB8zCg7hOfDOqzlkpFKJg@public.gmane.org>
2015-05-28  4:57     ` David Gibson
2015-05-28  4:57       ` David Gibson
2015-05-28  4:57   ` David Gibson
2015-06-01 10:29   ` Michael S. Tsirkin
2015-06-01 10:29     ` Michael S. Tsirkin
2015-06-01 23:38     ` David Miller
2015-06-01 23:38       ` David Miller
2015-04-24 12:24 ` [PATCH v6 3/8] macvtap: introduce macvtap_is_little_endian() helper Greg Kurz
2015-04-24 12:24   ` Greg Kurz
2015-04-27  9:08   ` Cornelia Huck
2015-04-27  9:08     ` Cornelia Huck
2015-05-28  4:58   ` David Gibson
2015-05-28  4:58   ` David Gibson
2015-06-01 10:30   ` Michael S. Tsirkin
2015-06-01 10:30     ` Michael S. Tsirkin
2015-06-01 23:38     ` David Miller
2015-06-01 23:38       ` David Miller
2015-04-24 12:24 ` [PATCH v6 4/8] vringh: introduce vringh_is_little_endian() helper Greg Kurz
2015-04-24 12:24   ` Greg Kurz
2015-04-27  9:09   ` Cornelia Huck
2015-04-27  9:09     ` Cornelia Huck
2015-05-28  4:58   ` David Gibson
2015-05-28  4:58   ` David Gibson
2015-04-24 12:25 ` [PATCH v6 5/8] vhost: introduce vhost_is_little_endian() helper Greg Kurz
2015-04-24 12:25   ` Greg Kurz
2015-04-27  9:09   ` Cornelia Huck
2015-04-27  9:09     ` Cornelia Huck
2015-05-28  4:58   ` David Gibson
2015-05-28  4:58   ` David Gibson
2015-04-24 12:26 ` [PATCH v6 6/8] virtio: add explicit big-endian support to memory accessors Greg Kurz
2015-04-24 12:26   ` Greg Kurz
     [not found]   ` <20150424122521.19156.65586.stgit-GiB8zCg7hOfDOqzlkpFKJg@public.gmane.org>
2015-04-27  9:14     ` Cornelia Huck
2015-04-27  9:14       ` Cornelia Huck
2015-04-27  9:14   ` Cornelia Huck
2015-05-28  4:59   ` David Gibson
2015-05-28  4:59     ` David Gibson
2015-04-24 12:27 ` [PATCH v6 7/8] vhost: cross-endian support for legacy devices Greg Kurz
2015-04-24 12:27   ` Greg Kurz
2015-04-27  9:17   ` Cornelia Huck
2015-04-27  9:17   ` Cornelia Huck
2015-05-28  4:59   ` David Gibson
2015-05-28  4:59     ` David Gibson
2015-04-24 12:50 ` [PATCH v6 8/8] macvtap/tun: cross-endian support for little-endian hosts Greg Kurz
2015-04-24 12:50   ` Greg Kurz
2015-05-28  4:59   ` David Gibson [this message]
2015-05-28  4:59     ` David Gibson
2015-04-24 13:31 ` [PATCH v6 0/8] vhost: support for cross endian guests Michael S. Tsirkin
     [not found] ` <20150424122211.19156.97626.stgit-GiB8zCg7hOfDOqzlkpFKJg@public.gmane.org>
2015-04-24 13:31   ` Michael S. Tsirkin
2015-04-24 13:31     ` Michael S. Tsirkin
     [not found]     ` <20150424153137-mutt-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-12 10:44       ` Greg Kurz
2015-05-12 10:44         ` Greg Kurz
     [not found]         ` <20150512124426.4e487cb6-GiB8zCg7hOfDOqzlkpFKJg@public.gmane.org>
2015-05-12 10:52           ` Michael S. Tsirkin
2015-05-12 10:52             ` Michael S. Tsirkin
2015-05-26  9:09             ` Greg Kurz
2015-05-26  9:09               ` Greg Kurz
2015-05-12 10:52         ` Michael S. Tsirkin
2015-05-12 10:44     ` Greg Kurz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150528045938.GI6681@voom.redhat.com \
    --to=david@gibson.dropbear.id.au \
    --cc=gkurz@linux.vnet.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=thuth@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.