All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steffen Klassert <steffen.klassert@secunet.com>
To: David Miller <davem@davemloft.net>
Cc: <alexander.h.duyck@redhat.com>, <alexander.duyck@gmail.com>,
	<netdev@vger.kernel.org>
Subject: Re: Looking for a lost patch
Date: Thu, 28 May 2015 07:51:52 +0200	[thread overview]
Message-ID: <20150528055150.GG27342@secunet.com> (raw)
In-Reply-To: <20150527.114603.897841724165037352.davem@davemloft.net>

On Wed, May 27, 2015 at 11:46:03AM -0400, David Miller wrote:
> From: Steffen Klassert <steffen.klassert@secunet.com>
> Date: Wed, 27 May 2015 10:35:16 +0200
> 
> > We currently check if a socket is attached to a skb and do socket
> > error notification in this case, otherwise we do PMTU discovery if
> > the packet is too big. Looks like this socket check is not sufficient
> > if the packet is already transmitted through a tunnel device.
> > 
> > I wonder if we have something to know that a packet was already
> > transmitted through a tunnel device. We could switch from socket
> > notification to PMTU discovery in this case.
> 
> Generally speaking, we should not be orphaning the socket as it
> traverses through tunnels.
> 
> In fact we have taken great pains to avoid doing this.

Yes, I'm aware of this. I don't want to orphan the socket,
all I wanted to do is to change the way we notify about MTU
changes. I.e. use icmpv6_send() instead of xfrm_local_error()
if the packet traversed a tunnel, that's why I wondered whether
we can know this.

      reply	other threads:[~2015-05-28  5:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-13 17:47 Looking for a lost patch Alexander Duyck
2015-05-18  7:38 ` Steffen Klassert
2015-05-18 16:02   ` Alexander Duyck
2015-05-19  7:57     ` Steffen Klassert
2015-05-19 18:32       ` Alexander Duyck
2015-05-20  6:32         ` Steffen Klassert
2015-05-21  2:06           ` Alexander Duyck
2015-05-21 21:25           ` David Miller
2015-05-27  8:35             ` Steffen Klassert
2015-05-27 15:46               ` David Miller
2015-05-28  5:51                 ` Steffen Klassert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150528055150.GG27342@secunet.com \
    --to=steffen.klassert@secunet.com \
    --cc=alexander.duyck@gmail.com \
    --cc=alexander.h.duyck@redhat.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.