Re: [meta-browser] [PATCH 2/2] chromium, cef: fetch chromium source from git

[Martin Jansa <martin.jansa@gmail.com>]

On Thu, May 28, 2015 at 09:09:24AM +0200, Zoltan Kuscsik wrote:
> On 28 May 2015 at 02:56, Khem Raj <raj.khem@gmail.com> wrote:
> > >
> > > +do_fetch_chromium_source_from_git() {
> > > +  cd ${S}
> > > +  export PATH=${WORKDIR}/depot_tools:"$PATH"
> > > +
> > > +  # Note: --deps-file needs to set to .DEPS.git for syncing to old
> > > +  # chromium versions
> > > +  gclient config ${CHROMIUM_SRC_GIT_URL} --deps-file=".DEPS.git"
> > > +
> > > +  # Runhooks is disabled. Running the hooks will trigger the
> > > +  # gyp_chromium command replaced with cef_create_projects.sh by
> > > +  # cef3.
> > > +
> > > +  gclient sync -f --nohooks --revision src@${CHROMIUM_SRC_GIT_COMMIT}
> > > +
> > > +  # We need the lastchange hook to generate the LASTCHANGE revision info
> > > +  # file.
> > > +
> > > +  python src/build/util/lastchange.py -o src/build/util/LASTCHANGE
> > > +}
> >
> >
> > small nit. formatting is not correct for this shell function.
> >
> 
> Z: Could you explain this in more details?

Use 4 spaces for indentation (everywhere).

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com