All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Arend van Spriel <arend@broadcom.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	Arend van Spriel <arend@broadcom.com>,
	"Fu, Zhonghui" <zhonghui.fu@linux.intel.com>
Subject: Re: brcmfmac: fix invalid access to struct acpi_device fields
Date: Thu, 28 May 2015 08:29:29 +0000 (UTC)	[thread overview]
Message-ID: <20150528082929.34ED7140394@smtp.codeaurora.org> (raw)
In-Reply-To: <1432747901-8472-1-git-send-email-arend@broadcom.com>


> The fields of struct acpi_device are only known when CONFIG_ACPI is
> defined. Fix this by using a helper function. This will resolve the
> issue found in linux-next:
> 
>  ../brcmfmac/bcmsdh.c: In function 'brcmf_ops_sdio_probe':
>  ../brcmfmac/bcmsdh.c:1139:7: error: dereferencing pointer to incomplete type
>    adev->flags.power_manageable = 0;
>        ^
> 
> Fixes: f0992ace680c ("brcmfmac: prohibit ACPI power management ...")
> Cc: Fu, Zhonghui <zhonghui.fu@linux.intel.com>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Arend van Spriel <arend@broadcom.com>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo

  reply	other threads:[~2015-05-28  8:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-27 17:31 [PATCH] brcmfmac: fix invalid access to struct acpi_device fields Arend van Spriel
2015-05-28  8:29 ` Kalle Valo [this message]
2015-05-28 16:48 ` Jason Andryuk
2015-05-28 18:31   ` Arend van Spriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150528082929.34ED7140394@smtp.codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=arend@broadcom.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=zhonghui.fu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.