From: Mark Brown <broonie@kernel.org>
To: yang.a.fang@intel.com
Cc: alsa-devel@alsa-project.org, srinivas.sripathi@intel.com,
praveen.k.jain@intel.com, lgirdwood@gmail.com,
denny.iriawan@intel.com, sathyanarayana.nujella@intel.com,
kevin.strasser@linux.intel.com, dgreid@chromium.org
Subject: Re: [PATCH 2/3] ASoC: ts3a227e: use device property api
Date: Thu, 28 May 2015 10:29:44 +0100 [thread overview]
Message-ID: <20150528092944.GS21577@sirena.org.uk> (raw)
In-Reply-To: <1432684686-14460-2-git-send-email-yang.a.fang@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 374 bytes --]
On Tue, May 26, 2015 at 04:58:05PM -0700, yang.a.fang@intel.com wrote:
> -static int ts3a227e_parse_dt(struct ts3a227e *ts3a227e, struct device_node *np)
> +static int ts3a227e_parse_dt(struct ts3a227e *ts3a227e, struct device *dev)
You should rename the function - it's not just parsing DT, it's also
parsing ACPI (and any other firmware interface that comes along) now.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2015-05-28 9:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 23:58 [PATCH 1/3] ASoC: max98090: read micbias from device property yang.a.fang
2015-05-26 23:58 ` [PATCH 2/3] ASoC: ts3a227e: use device property api yang.a.fang
2015-05-28 9:29 ` Mark Brown [this message]
2015-05-26 23:58 ` [PATCH 3/3] ASoC: Intel: fixed TI button detection yang.a.fang
2015-05-27 4:39 ` [PATCH 1/3] ASoC: max98090: read micbias from device property Dylan Reid
2015-05-27 17:26 ` Yang Fang
2015-05-28 9:28 ` Mark Brown
2015-05-28 18:00 ` [PATCH v2 " yang.a.fang
2015-05-28 18:00 ` [PATCH v2 2/3] ASoC: ts3a227e: use device property api yang.a.fang
2015-05-28 18:00 ` [PATCH v2 3/3] ASoC: Intel: fixed TI button detection yang.a.fang
2015-05-29 9:58 ` [PATCH v2 1/3] ASoC: max98090: read micbias from device property Mark Brown
2015-05-29 17:37 ` Fang, Yang A
2015-05-29 18:56 ` [PATCH v3 " yang.a.fang
2015-05-29 18:56 ` [PATCH v3 2/3] ASoC: ts3a227e: use device property api yang.a.fang
2015-06-02 17:17 ` Mark Brown
2015-05-29 18:56 ` [PATCH v3 3/3] ASoC: Intel: fixed TI button detection yang.a.fang
2015-06-03 18:15 ` Mark Brown
2015-06-03 20:54 ` Fang, Yang A
2015-06-03 22:07 ` [PATCH v4] " yang.a.fang
2015-06-15 9:51 ` Mark Brown
2015-06-02 17:11 ` [PATCH v3 1/3] ASoC: max98090: read micbias from device property Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150528092944.GS21577@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=denny.iriawan@intel.com \
--cc=dgreid@chromium.org \
--cc=kevin.strasser@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=praveen.k.jain@intel.com \
--cc=sathyanarayana.nujella@intel.com \
--cc=srinivas.sripathi@intel.com \
--cc=yang.a.fang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.