From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753967AbbE1LUQ (ORCPT ); Thu, 28 May 2015 07:20:16 -0400 Received: from casper.infradead.org ([85.118.1.10]:57244 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753467AbbE1LUK (ORCPT ); Thu, 28 May 2015 07:20:10 -0400 Date: Thu, 28 May 2015 13:20:02 +0200 From: Peter Zijlstra To: Rusty Russell Cc: mingo@kernel.org, mathieu.desnoyers@efficios.com, oleg@redhat.com, paulmck@linux.vnet.ibm.com, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, andi@firstfloor.org, rostedt@goodmis.org, tglx@linutronix.de, laijs@cn.fujitsu.com, linux@horizon.com Subject: Re: [PATCH v5 00/10] latched RB-trees and __module_address() Message-ID: <20150528112002.GE3644@twins.programming.kicks-ass.net> References: <20150413141126.756350256@infradead.org> <87wq1fs9ha.fsf@rustcorp.com.au> <20150414064149.GM23123@twins.programming.kicks-ass.net> <87zj4pwj3e.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zj4pwj3e.fsf@rustcorp.com.au> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 28, 2015 at 11:37:17AM +0930, Rusty Russell wrote: > That's rcu_read_lock_sched_held, not rcu_held_lock_sched_held(). > > Also, your unlikely is weird and backwards. > > I changed it as below, and folded. It's in modules-next. > > I'm now going to do some *actual* testing, and I'll go all Torvalds on > you if this spews warnings... Fair enough, I did see the build robot fail on this. How come those only showed up now? This patch has been in your git tree for a long time; you picked up the rcu validation patches before the other ones.