From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54806)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@xilinx.com>) id 1Yxxun-0004wC-T4
	for qemu-devel@nongnu.org; Thu, 28 May 2015 09:32:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@xilinx.com>) id 1Yxxuf-00005i-6u
	for qemu-devel@nongnu.org; Thu, 28 May 2015 09:32:05 -0400
Received: from mail-bn1on0092.outbound.protection.outlook.com
	([157.56.110.92]:63856
	helo=na01-bn1-obe.outbound.protection.outlook.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@xilinx.com>) id 1Yxxuf-00005e-1m
	for qemu-devel@nongnu.org; Thu, 28 May 2015 09:31:57 -0400
Date: Thu, 28 May 2015 23:27:54 +1000
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
Message-ID: <20150528132753.GM27042@toto>
References: <1432060414-5195-1-git-send-email-peter.maydell@linaro.org>
	<1432060414-5195-12-git-send-email-peter.maydell@linaro.org>
	<20150528125035.GL27042@toto>
	<CAFEAcA-XFq3ugrkU0URU7snGm0wMV5Dhp6Gj+bz4UKesJm2kPA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CAFEAcA-XFq3ugrkU0URU7snGm0wMV5Dhp6Gj+bz4UKesJm2kPA@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 11/14] target-arm: Extend FP checks to use
	an EL
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Alexander Graf <agraf@suse.de>, Sergey Fedorov <serge.fdrv@gmail.com>, Alex =?iso-8859-1?Q?Benn=E9e?= <alex.bennee@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>, Patch Tracking <patches@linaro.org>

On Thu, May 28, 2015 at 02:19:42PM +0100, Peter Maydell wrote:
> On 28 May 2015 at 13:50, Edgar E. Iglesias <edgar.iglesias@xilinx.com> wrote:
> > On Tue, May 19, 2015 at 07:33:31PM +0100, Peter Maydell wrote:
> >> +    /* For the CPTR registers we don't need to guard with an ARM_FEATURE
> >> +     * check because zero bits in the registers mean "don't trap".
> >> +     */
> >> +
> >> +    /* CPTR_EL2 : present in v7VE or v8 */
> >> +    if (cur_el <= 2 && extract32(env->cp15.cptr_el[2], 10, 1)
> >> +        && arm_is_secure_below_el3(env)) {
> >
> > I think this should be !arm_is_secure_below_el3(env)
> 
> Yes.
> 
> > Also the ARMv7 manual, the part describing CPACR cpn bits, indicates that
> > HCTPR has prio over CPACR. I didn't find any thing like that for
> > ARMv8... There might be a difference between v8/v7 here, do you know?
> 
> For v8, this is described in "G1.11.2 Exception priority order" I think:
> exceptions taken to EL1 because of configurable access to insns
> are item 8, which has higher priority than HCPTR traps (item 10).
> This matches the code I have in this patch.
> 
> I believe that v7 is the same, and the v7 ARM ARM is just slightly
> confusingly worded. The HCPTR documentation says that setting TCPn
> to 1 traps "any otherwise-valid Non-secure access to CPn". The
> CheckAdvSIMDOrVFPEnabled() pseudocode also clearly checks CPACR
> first and HCPTR second.

Thanks for clarifying that. With the !arm_is_secure_below_el3(env)
change:

Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>

Cheers,
Edgar