From: bp@alien8.de (Borislav Petkov)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] EDAC: Cleanup atomic_scrub mess
Date: Thu, 28 May 2015 15:37:06 +0200 [thread overview]
Message-ID: <20150528133706.GC31800@pd.tnic> (raw)
In-Reply-To: <20150528123448.GA2067@n2100.arm.linux.org.uk>
On Thu, May 28, 2015 at 01:34:49PM +0100, Russell King - ARM Linux wrote:
> Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
Thanks!
I've got all the ACKs now :-)
>
> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > index 45df48ba0b12..325d6f3a596a 100644
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -15,6 +15,8 @@ config ARM
> > select CLONE_BACKWARDS
> > select CPU_PM if (SUSPEND || CPU_IDLE)
> > select DCACHE_WORD_ACCESS if HAVE_EFFICIENT_UNALIGNED_ACCESS
> > + select EDAC_SUPPORT
> > + select EDAC_ATOMIC_SCRUB
>
> I wonder if it would make sense to conditionalise EDAC_SUPPORT on...
> if CPU_32v6 || CPU_32v7
I guess you can.
Especially if no newer 32-bit ARM would need the scrubbing anymore.
Disadvantage is, if turns out CPU_32v8 (would there even be v8, no
idea...) and newer would need it after all, you'd have to explicitly
enable it.
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>
To: Russell King - ARM Linux <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
Cc: Loc Ho <lho-qTEPVZfXA3Y@public.gmane.org>,
Doug Thompson
<dougthompson-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>,
Mauro Carvalho Chehab
<mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
linux-edac-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
Jon Masters <jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"patches-qTEPVZfXA3Y@public.gmane.org"
<patches-qTEPVZfXA3Y@public.gmane.org>,
Ralf Baechle <ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>,
Benjamin Herrenschmidt
<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
Paul Mackerras <paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>,
Michael Ellerman <mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>,
Chris Metcalf <cmetcalf-d5a29ZRxExrQT0dZR+AlfA@public.gmane.org>,
x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
Markos Chandras
<markos.chandras-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>,
"Steven J. Hill"
<Steven.Hill-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>,
". Maciej W. Rozycki"
<macro-qD8j1LwMmJjtCj0u4l0SBw@public.gmane.org>
Subject: Re: [RFC PATCH] EDAC: Cleanup atomic_scrub mess
Date: Thu, 28 May 2015 15:37:06 +0200 [thread overview]
Message-ID: <20150528133706.GC31800@pd.tnic> (raw)
In-Reply-To: <20150528123448.GA2067-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
On Thu, May 28, 2015 at 01:34:49PM +0100, Russell King - ARM Linux wrote:
> Acked-by: Russell King <rmk+kernel-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
Thanks!
I've got all the ACKs now :-)
>
> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > index 45df48ba0b12..325d6f3a596a 100644
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -15,6 +15,8 @@ config ARM
> > select CLONE_BACKWARDS
> > select CPU_PM if (SUSPEND || CPU_IDLE)
> > select DCACHE_WORD_ACCESS if HAVE_EFFICIENT_UNALIGNED_ACCESS
> > + select EDAC_SUPPORT
> > + select EDAC_ATOMIC_SCRUB
>
> I wonder if it would make sense to conditionalise EDAC_SUPPORT on...
> if CPU_32v6 || CPU_32v7
I guess you can.
Especially if no newer 32-bit ARM would need the scrubbing anymore.
Disadvantage is, if turns out CPU_32v8 (would there even be v8, no
idea...) and newer would need it after all, you'd have to explicitly
enable it.
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-05-28 13:37 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 23:24 [PATCH v10 0/4] edac: Add APM X-Gene SoC EDAC driver Loc Ho
2015-05-18 23:24 ` Loc Ho
2015-05-18 23:24 ` [PATCH v10 1/5] arm64: Enable EDAC on ARM64 Loc Ho
2015-05-18 23:24 ` Loc Ho
2015-05-18 23:24 ` [PATCH v10 2/5] MAINTAINERS: Add entry for APM X-Gene SoC EDAC driver Loc Ho
2015-05-18 23:24 ` Loc Ho
2015-05-18 23:24 ` [PATCH v10 3/5] Documentation: Add documentation for the APM X-Gene SoC EDAC DTS binding Loc Ho
2015-05-18 23:24 ` Loc Ho
2015-05-18 23:24 ` [PATCH v10 4/5] edac: Add APM X-Gene SoC EDAC driver Loc Ho
2015-05-18 23:24 ` Loc Ho
2015-05-18 23:24 ` [PATCH v10 5/5] arm64: Add APM X-Gene SoC EDAC DTS entries Loc Ho
2015-05-18 23:24 ` Loc Ho
2015-05-22 8:23 ` [PATCH v10 4/5] edac: Add APM X-Gene SoC EDAC driver Arnd Bergmann
2015-05-22 8:23 ` Arnd Bergmann
2015-05-22 8:46 ` Borislav Petkov
2015-05-22 8:46 ` Borislav Petkov
2015-05-22 8:55 ` Arnd Bergmann
2015-05-22 8:55 ` Arnd Bergmann
2015-05-22 18:28 ` Loc Ho
2015-05-22 18:28 ` Loc Ho
2015-05-22 18:25 ` Loc Ho
2015-05-22 18:25 ` Loc Ho
2015-05-22 8:59 ` Arnd Bergmann
2015-05-22 8:59 ` Arnd Bergmann
2015-05-22 8:02 ` [PATCH v10 3/5] Documentation: Add documentation for the APM X-Gene SoC EDAC DTS binding Arnd Bergmann
2015-05-22 8:02 ` Arnd Bergmann
2015-05-19 17:03 ` [PATCH v10 1/5] arm64: Enable EDAC on ARM64 Borislav Petkov
2015-05-19 17:03 ` Borislav Petkov
2015-05-19 19:57 ` Loc Ho
2015-05-19 19:57 ` Loc Ho
2015-05-19 20:33 ` Borislav Petkov
2015-05-19 20:33 ` Borislav Petkov
2015-05-21 18:07 ` Borislav Petkov
2015-05-21 18:07 ` Borislav Petkov
2015-05-21 18:11 ` [RFC PATCH] EDAC: Cleanup atomic_scrub mess Borislav Petkov
2015-05-21 18:11 ` Borislav Petkov
2015-05-22 20:13 ` Chris Metcalf
2015-05-22 20:13 ` Chris Metcalf
2015-05-27 15:52 ` Borislav Petkov
2015-05-27 15:52 ` Borislav Petkov
2015-05-28 2:27 ` Michael Ellerman
2015-05-28 2:27 ` Michael Ellerman
2015-05-28 12:34 ` Russell King - ARM Linux
2015-05-28 12:34 ` Russell King - ARM Linux
2015-05-28 13:37 ` Borislav Petkov [this message]
2015-05-28 13:37 ` Borislav Petkov
2015-05-22 8:24 ` [PATCH v10 0/4] edac: Add APM X-Gene SoC EDAC driver Arnd Bergmann
2015-05-22 8:24 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150528133706.GC31800@pd.tnic \
--to=bp@alien8.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.