Re: [PATCH,RFC bluetooth-next 1/2] ieee802154: Fix generation of random EUI-64 addresses.

[Alexander Aring <alex.aring@gmail.com>]

Hi,

On Thu, May 28, 2015 at 05:13:15PM +0200, Phoebe Buckheister wrote:
> On Thu, 28 May 2015 15:38:32 +0300
> Lennert Buytenhek <buytenh@wantstofly.org> wrote:
> 
> > Currently, ieee802154_random_extended_addr() has a 50% chance of
> > generating a group (multicast) address, while this function is used
> > for generating station addresses (which can't be group addresses)
> > for interfaces that don't have a hardware-provided address.
> > 
> > Also, in case get_random_bytes() generates the EUI-64 address
> > 00:00:00:00:00:00:00:00 (extremely unlikely), which is an invalid
> > address, ieee802154_random_extended_addr() reacts by changing it
> > to 01:00:00:00:00:00:00:00, which is an invalid station address as
> > well, as it is a group address.
> > 
> > This patch changes the address generation procedure to grab eight
> > random bytes, treat that as an EUI-64, and then clear the Group
> > address bit and set the Locally Administered bit, which is in
> > line with how eth_random_addr() generates random EUI-48s.
> 
> Looks good to me. Even if this ends up being uneccessarily strict, we'll
> always have a huge pool of addresses we may generate.
> Note: the standard only says that the address shall be a 64 bit
> universal address (not excluding multicast), but not generating
> multicast EUIs seems like a good idea anyway.
>  

thanks Phoebe for clarify this. You both convince me to change it.

Thanks that we clarify this.

> > Signed-off-by: Lennert Buytenhek <buytenh@wantstofly.org>

Acked-by: Alexander Aring <alex.aring@gmail.com>