From: Theodore Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: "fstests@vger.kernel.org" <fstests@vger.kernel.org>
Subject: Re: [PATCH 1/2] fsstress: add the [-l loops] option
Date: Thu, 28 May 2015 14:25:09 -0400 [thread overview]
Message-ID: <20150528182509.GD18540@thunk.org> (raw)
In-Reply-To: <DD1100D8-2CD7-49B8-A046-B18BC68A87B5@sandeen.net>
On Wed, May 27, 2015 at 08:32:23PM -0500, Eric Sandeen wrote:
>
> > +errout:
> > + chdir("..");
>
> This seems unrelated, no?
This is needed to so that we leave doproc with the same CWD that we
entered with. At the beginning of the doproc, we do the eqvuialent of
mkdir -p pN
cd pN
(where N is 0, 1, 2, 3, ..)
previously doproc was only executed once, so it didn't matter what the
CWD was when we were doing with doproc(). But since with this patch
we are now calling doproc in the loop, the chdir("..") is required or
each successive loop will result in a new p0 directory being created,
and then at the end of the run, the files will be in
.../p0/p0/p0/p0/p0/p0/p0/p0/p0/...
- Ted
next prev parent reply other threads:[~2015-05-28 18:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 0:58 [PATCH 1/2] fsstress: add the [-l loops] option Theodore Ts'o
2015-05-28 0:58 ` [PATCH 2/2] fsstress: add the -c option Theodore Ts'o
2015-05-28 1:32 ` [PATCH 1/2] fsstress: add the [-l loops] option Eric Sandeen
2015-05-28 18:25 ` Theodore Ts'o [this message]
2015-05-28 18:49 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150528182509.GD18540@thunk.org \
--to=tytso@mit.edu \
--cc=fstests@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.