All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Jan Beulich <JBeulich@suse.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ix86: really make user_mode() work correctly for VM86 mode
Date: Fri, 29 May 2015 09:49:15 +0200	[thread overview]
Message-ID: <20150529074915.GA23623@gmail.com> (raw)
In-Reply-To: <CALCETrUC_pd3X0DgP3=ROyHKeKga1KfjG6ao7h2f1DzDfzyPmQ@mail.gmail.com>


* Andy Lutomirski <luto@amacapital.net> wrote:

> On May 28, 2015 1:16 AM, "Jan Beulich" <JBeulich@suse.com> wrote:
> >
> > While commit efa7045103 ("x86/asm/entry: Make user_mode() work
> > correctly if regs came from VM86 mode") claims that "user_mode() is now
> > identical to user_mode_vm()", this wasn't actually the case - no prior
> > commit made it so.
> 
> That's embarrassing!  I'm not sure how I screwed that up.

I should have noticed it too :-/

In fact I remember that I wanted to double check it all because the algorithmic 
complexity of the new test looked suspiciously too simple on the 32-bit side (we 
_did_ have a legitimate reason to keep the API split originally) - but forgot 
about it.

> Acked-by: Andy Lutomirski <luto@kernel.org>
> 
> This is needed for x86/urgent.

Yeah, queued it up.

> [...]  I'll see if I can write a simple test case, too.  My old do_bounds test 
> should be a good start.

That kind of test would be absolutely fantastic to have.

Thanks,

	Ingo

  reply	other threads:[~2015-05-29  7:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-28  8:16 [PATCH] ix86: really make user_mode() work correctly for VM86 mode Jan Beulich
2015-05-28 17:33 ` Andy Lutomirski
2015-05-29  7:49   ` Ingo Molnar [this message]
2015-05-29  7:51 ` [tip:x86/urgent] x86/asm/entry/32: Really " tip-bot for Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150529074915.GA23623@gmail.com \
    --to=mingo@kernel.org \
    --cc=JBeulich@suse.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.