From mboxrd@z Thu Jan 1 00:00:00 1970 From: vinod.koul@intel.com (Vinod Koul) Date: Fri, 29 May 2015 14:43:45 +0530 Subject: [PATCH] fixup! dmaengine: pxa_dma: add debug information In-Reply-To: <1432761820-32072-1-git-send-email-robert.jarzmik@free.fr> References: <1432761820-32072-1-git-send-email-robert.jarzmik@free.fr> Message-ID: <20150529091345.GE3140@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, May 27, 2015 at 11:23:40PM +0200, Robert Jarzmik wrote: > This fixes the following error: > drivers/dma/pxa_dma.c: In function ?dbg_show_requester_chan?: > drivers/dma/pxa_dma.c:192:2: error: void value not ignored as it ought to be > pos += seq_printf(s, "DMA channel %d requester :\n", phy->idx); > ^ > drivers/dma/pxa_dma.c:197:8: error: void value not ignored as it ought to be > !!(drcmr & DRCMR_MAPVLD)); > ^ > scripts/Makefile.build:258: recipe for target 'drivers/dma/pxa_dma.o' failed Applied now, but not pleased that you sent broken code. Sending stuff that compiles is basic step -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755893AbbE2JMv (ORCPT ); Fri, 29 May 2015 05:12:51 -0400 Received: from mga11.intel.com ([192.55.52.93]:39343 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755565AbbE2JMr (ORCPT ); Fri, 29 May 2015 05:12:47 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,516,1427785200"; d="scan'208";a="702023306" Date: Fri, 29 May 2015 14:43:45 +0530 From: Vinod Koul To: Robert Jarzmik Cc: Daniel Mack , Haojian Zhuang , linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fixup! dmaengine: pxa_dma: add debug information Message-ID: <20150529091345.GE3140@localhost> References: <1432761820-32072-1-git-send-email-robert.jarzmik@free.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1432761820-32072-1-git-send-email-robert.jarzmik@free.fr> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 27, 2015 at 11:23:40PM +0200, Robert Jarzmik wrote: > This fixes the following error: > drivers/dma/pxa_dma.c: In function ‘dbg_show_requester_chan’: > drivers/dma/pxa_dma.c:192:2: error: void value not ignored as it ought to be > pos += seq_printf(s, "DMA channel %d requester :\n", phy->idx); > ^ > drivers/dma/pxa_dma.c:197:8: error: void value not ignored as it ought to be > !!(drcmr & DRCMR_MAPVLD)); > ^ > scripts/Makefile.build:258: recipe for target 'drivers/dma/pxa_dma.o' failed Applied now, but not pleased that you sent broken code. Sending stuff that compiles is basic step -- ~Vinod