Re: [PATCHv2 bluetooth-next 3/4] ieee802154/atusb: Add .set_promiscuous_mode driver operation

[Alexander Aring <alex.aring@gmail.com>]

Hi Stefan,

On Fri, May 29, 2015 at 10:51:27AM +0200, Stefan Schmidt wrote:
> From: Stefan Schmidt <s.schmidt@samsung.com>
> 
> Allow monitor mode operation with disabled AACK in hardware.
> 
> Signed-off-by: Stefan Schmidt <stefan@osg.samsung.com>
> ---
>  drivers/net/ieee802154/atusb.c | 30 +++++++++++++++++++++++++++++-
>  1 file changed, 29 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c
> index 9805ebe..3d25678 100644
> --- a/drivers/net/ieee802154/atusb.c
> +++ b/drivers/net/ieee802154/atusb.c
> @@ -473,6 +473,33 @@ atusb_set_txpower(struct ieee802154_hw *hw, s32 mbm)
>  	return -EINVAL;
>  }
>  
> +static int
> +atusb_set_promiscuous_mode(struct ieee802154_hw *hw, const bool on)
> +{
> +	struct atusb *atusb = hw->priv;
> +	int ret;
> +
> +	if (on) {
> +		ret = atusb_write_subreg(atusb, SR_AACK_DIS_ACK, 1);
> +		if (ret < 0)
> +			return ret;
> +
> +		ret = atusb_write_subreg(atusb, SR_AACK_PROM_MODE, 1);
> +		if (ret < 0)
> +			return ret;
> +	} else {
> +		ret = atusb_write_subreg(atusb, SR_AACK_PROM_MODE, 0);
> +		if (ret < 0)
> +			return ret;
> +
> +		ret = atusb_write_subreg(atusb, SR_AACK_DIS_ACK, 0);
> +		if (ret < 0)
> +			return ret;
> +	}
> +
> +	return 0;
> +}
> +

In case of rzusb which have an at86rf230 it doesn't support these
registers. There is no support for promiscuous mode. It's then a
broken behaviour when somebody sets this in rzusb.

Anyway rzusb isn't currently supported and I just want to leave a note
here. It's fine for me. Something for later to fix it in driver or
firmware handling.

- Alex