From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Nicholas Mc Guire <der.herr@hofr.at>
Cc: Nicholas Mc Guire <hofrat@osadl.org>,
Michael Holzheu <holzheu@linux.vnet.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux390@de.ibm.com, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] s390/sclp: pass timeout as HZ independent value
Date: Fri, 29 May 2015 12:35:23 +0200 [thread overview]
Message-ID: <20150529103523.GB4169@osiris> (raw)
In-Reply-To: <20150529095154.GB9952@opentech.at>
On Fri, May 29, 2015 at 11:51:54AM +0200, Nicholas Mc Guire wrote:
> On Fri, 29 May 2015, Heiko Carstens wrote:
> > Yes, the orginal code seems to be broken. Since I've no idea what the intended
> > timeout value should be, let's simply ask Michael, who wrote this code eight
> > years ago ;)
> > While these lines get touched anyway, it would make sense to use
> > schedule_timeout_interruptible() instead, and get rid of set_current_state().
> >
> Well that is not really equivalent
> schedule_timeout_interruptible() is doing
> __set_current_state not set_current_state
> so that would drop the mb() and no WRITE_ONCE()
And how does that matter in this case?
next prev parent reply other threads:[~2015-05-29 10:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 17:04 [PATCH RFC] s390/sclp: pass timeout as HZ independent value Nicholas Mc Guire
2015-05-29 9:07 ` Heiko Carstens
2015-05-29 9:51 ` Nicholas Mc Guire
2015-05-29 10:35 ` Heiko Carstens [this message]
2015-05-29 11:49 ` Nicholas Mc Guire
2015-05-29 12:01 ` Michael Holzheu
2015-05-29 14:16 ` Nicholas Mc Guire
2015-05-29 14:36 ` Heiko Carstens
2015-05-29 14:43 ` Nicholas Mc Guire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150529103523.GB4169@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=der.herr@hofr.at \
--cc=hofrat@osadl.org \
--cc=holzheu@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.