All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Wang Nan <wangnan0@huawei.com>,
	linux-kernel@vger.kernel.org, lizefan@huawei.com,
	mingo@redhat.com
Subject: Re: [PATCH tip/perf/core] perf probe: Fix 'function unused' warning
Date: Fri, 29 May 2015 10:29:55 -0300	[thread overview]
Message-ID: <20150529132955.GR24859@kernel.org> (raw)
In-Reply-To: <5566A731.9090707@hitachi.com>

Em Thu, May 28, 2015 at 02:27:13PM +0900, Masami Hiramatsu escreveu:
> On 2015/05/28 11:25, Wang Nan wrote:
> > By 'make build-test' a warning is found in probe-event.c that, after
> > commit 419e873828 (perf probe: Show the error reason comes from
> > invalid DSO) the only user of kernel_get_module_dso() is
> > open_debuginfo(). Which is not compiled if HAVE_DWARF_SUPPORT not set.
> > 'make build-test' found this problem when make_minimal.
> 
> Ah, right!
> 
> > 
> > This patch moves kernel_get_module_dso() to HAVE_DWARF_SUPPORT ifdef
> > section.
> > 
> > Signed-off-by: Wang Nan <wangnan0@huawei.com>
> 
> Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>

Thanks, applied!

- Arnaldo

  reply	other threads:[~2015-05-29 13:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-28  2:25 [PATCH tip/perf/core] perf probe: Fix 'function unused' warning Wang Nan
2015-05-28  5:27 ` Masami Hiramatsu
2015-05-29 13:29   ` Arnaldo Carvalho de Melo [this message]
2015-05-29 18:35 ` [tip:perf/core] " tip-bot for Wang Nan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150529132955.GR24859@kernel.org \
    --to=acme@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@redhat.com \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.