Re: [Qemu-devel] [PATCH 2/2] Compile time checks for newer glib

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Paolo Bonzini (pbonzini@redhat.com) wrote:
> 
> 
> On 29/05/2015 17:01, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> > 
> > Newer glib has support for checking that applications aren't
> > using newer glib calls than they should be.
> > 
> > The support for the check only went into glib 2.32 and it only
> > has macros for version 2.26 upwards; although we only insist
> > on 2.22 at the moment, I set the glib checks to the earliest of 2.26,
> > it wont cause problems on anything <2.32 since the checks aren't
> > there.
> 
> I think we need 2.32 minimum, because we use the 2.32 mutex/condvar
> functions if available.

Are all those done via glib-compat.h ?
Note that in the patch I turn off the version checks at the top of glib-compat.h
on the assumption that anything trying to use it knows what it is doing.

Dave

> 
> Paolo
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK