From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756621AbbE2RVf (ORCPT ); Fri, 29 May 2015 13:21:35 -0400 Received: from hofr.at ([212.69.189.236]:48355 "EHLO mail.hofr.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753184AbbE2RV2 (ORCPT ); Fri, 29 May 2015 13:21:28 -0400 Date: Fri, 29 May 2015 19:21:26 +0200 From: Nicholas Mc Guire To: Dan Carpenter Cc: Nicholas Mc Guire , Lidza Louina , devel@driverdev.osuosl.org, Greg Kroah-Hartman , driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] staging: dgnc: switch timeout to signed type Message-ID: <20150529172126.GA27992@opentech.at> References: <1432917688-20228-1-git-send-email-hofrat@osadl.org> <1432917688-20228-2-git-send-email-hofrat@osadl.org> <20150529170522.GP28762@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150529170522.GP28762@mwanda> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 May 2015, Dan Carpenter wrote: > On Fri, May 29, 2015 at 06:41:28PM +0200, Nicholas Mc Guire wrote: > > The schedule_timeout*() helpers take the timeout as signed long, as > > ch_close_delay in struct channel_t was not used for other purposes its > > type was switched to signed long and the declarations fixed up. > > Uh, we never pass it to schedule_timeout etc and even if we did how > would that matter? It's either 250 or 0. > > What is the bug you are trying to fix and we can help you? > static code checkers being unhappy with type mismatch automatic type conversion is ok if necessary but in this case it simply is not as the ch_close_delay is only being used in this one place so why not do it type clean ? I'll turn the question around - what reason would there be to go through type conversion if it is not needed ? thx! hofrat