Re: [PATCH V4 5/8] tools/libxl: Set 'reg' of cpu node equal to MPIDR affinity for domU

[Chen Baozi <cbz@baozis.org>]

On Sat, May 30, 2015 at 10:08:21AM +0800, Chen Baozi wrote:
> Hi Julien,
> 
> On Fri, May 29, 2015 at 05:08:08PM +0100, Julien Grall wrote:
> > On 29/05/15 16:55, Ian Campbell wrote:
> > > On Fri, 2015-05-29 at 16:44 +0100, Julien Grall wrote:
> > > 
> > >>> +        name = GCSPRINTF("cpu@%lx", mpidr_aff);
> > >>
> > >> It's not necessary to change the cpu@.
> > > 
> > > AIUI it is conventional in DT for this to match the first reg entry.
> > 
> > Well, it's conventional when the reg field is containing an address.
> > 
> > It's not the case of the cpu node as "reg" doesn't contain an address.
> > There is a mix of both in the different DTS.
> > 
> > Although, increment an ID make easier to read the dumped DTS for debugging.
> 
> I did the change because it would be more friendly for user to read the
> cpu node in /proc/device-tree/. Because the number is no longer continuous
> when we have a guest more than 16 cpus. In that case, the cpu nodes will be
> looked like as the following:
> 
> cpu@0, cpu@1, ..., cpu@15, cpu@256, cpu@257, ..., cpu@271, cpu@512, ...

Ah, I misundertood your comment. I think what you mean here is to keep the
name as "cpu@i" not about the form of the "cpu@%d".

However, I still prefer the new form :)

Cheers,

Baozi.