From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YyZHL-0007zJ-4v for mharc-grub-devel@gnu.org; Sat, 30 May 2015 01:25:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37030) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YyZHI-0007z8-UW for grub-devel@gnu.org; Sat, 30 May 2015 01:25:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YyZHF-0002j4-P0 for grub-devel@gnu.org; Sat, 30 May 2015 01:25:48 -0400 Received: from mail-la0-x22e.google.com ([2a00:1450:4010:c03::22e]:33626) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YyZHF-0002i7-AZ for grub-devel@gnu.org; Sat, 30 May 2015 01:25:45 -0400 Received: by labpy14 with SMTP id py14so57556863lab.0 for ; Fri, 29 May 2015 22:25:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=PVpKcOnpDZ0DH8DyhYs6yy/EZ/Yt2e8D8HtNTxLBP/M=; b=lvRvQxh5xJ6JQmAjz0DZRMzfJiVsGRGuI+KmZgt6DUKjpbmh2rHUT5K0jlqZlkPZqo nUISFvTGb5ZILRj3SCzRpGYFkZ65fC4ab18u0IRBhuNnHNW/mJ3pQa6xs8+2X3hSt+Su 9DQhnjMRlTPe1fXRj5JvKGDZgde2aVCh546fvqF+A49YyvFCospbEfuXxrY8GmfNFjvW GTu7oTnJ5+08ZhEVgVF8FQruvdp3ef7K63Wm4a7yxr/WrI5ICUSzwnH3YdUODqMLRRLK p92W4J0Tj4dh6lYoXRm2RRJnycIikDhJP7W/0cZTMpIa1bu4souxRuTmhrhCOzgmKqhy VOuw== X-Received: by 10.153.5.37 with SMTP id cj5mr1378323lad.90.1432963544547; Fri, 29 May 2015 22:25:44 -0700 (PDT) Received: from opensuse.site (ppp91-76-14-38.pppoe.mtu-net.ru. [91.76.14.38]) by mx.google.com with ESMTPSA id w9sm2039135lbm.24.2015.05.29.22.25.43 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 May 2015 22:25:43 -0700 (PDT) Date: Sat, 30 May 2015 08:25:42 +0300 From: Andrei Borzenkov To: Daniel Kiper Subject: Re: [PATCH 3/5] i386/relocator: Remove unused avoid_efi_bootservices argument Message-ID: <20150530082542.1fc95f55@opensuse.site> In-Reply-To: <20150529205843.GL3787@olila.local.net-space.pl> References: <1422640768-28181-1-git-send-email-daniel.kiper@oracle.com> <1422640768-28181-4-git-send-email-daniel.kiper@oracle.com> <554B8D05.4000004@gmail.com> <20150529205843.GL3787@olila.local.net-space.pl> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.27; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::22e Cc: jgross@suse.com, grub-devel@gnu.org, keir@xen.org, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, Vladimir =?UTF-8?B?J8+GLWNvZGVyL3BoY29kZXIn?= Serbinenko , roy.franz@linaro.org, ning.sun@intel.com, david.vrabel@citrix.com, jbeulich@suse.com, andrew.cooper3@citrix.com, xen-devel@lists.xenproject.org, qiaowei.ren@intel.com, richard.l.maliszewski@intel.com, gang.wei@intel.com, fu.wei@linaro.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 May 2015 05:25:49 -0000 =D0=92 Fri, 29 May 2015 22:58:43 +0200 Daniel Kiper =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > Another questions is why grub_relocator_alloc_chunk_addr() does not consu= lt EFI > memory map if grub_relocator_alloc_chunk_align() does. Should not we fix = it? My best guess is that grub_relocator_alloc_chunk_addr() gets target from elsewhere so there is nothing to consult (it is caller responsibility); while grub_relocator_alloc_chunk_align() needs to actually search for suitable memory region.