From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.free-electrons.com (down.free-electrons.com. [37.187.137.238]) by gmr-mx.google.com with ESMTP id ha2si19842wib.1.2015.05.30.14.56.34 for ; Sat, 30 May 2015 14:56:34 -0700 (PDT) Date: Sat, 30 May 2015 23:56:34 +0200 From: Alexandre Belloni To: Jan Kardell Cc: Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Vincent Donnefort , Dan Carpenter , oen@telliq.com Subject: [rtc-linux] Re: [PATCH v3] rtc: pcf8563 fix: return -EINVAL if we read an invalid time. Message-ID: <20150530215634.GL2185@piout.net> References: <1432795725-8350-1-git-send-email-jan.kardell@telliq.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <1432795725-8350-1-git-send-email-jan.kardell@telliq.com> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 28/05/2015 at 08:48:45 +0200, Jan Kardell wrote : > Return -EINVAL if the voltage low bit is set to avoid getting a bogus > time at boot. > There was a comment stating that util-linux hwclock refuses to set a > new time if we return an error code on read, but at least the current > version do set the time as expected. Remove the comment and the check > for valid time, and let the rtc core check it for us. > > Changes in v2: Remove the test for invalid time. Change dev_err to > dev_info when voltage low is set. > > Changes in v3: Use dev_err when voltage low is set. > > Signed-off-by: Jan Kardell > --- > drivers/rtc/rtc-pcf8563.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756632AbbE3V4o (ORCPT ); Sat, 30 May 2015 17:56:44 -0400 Received: from down.free-electrons.com ([37.187.137.238]:33591 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753942AbbE3V4f (ORCPT ); Sat, 30 May 2015 17:56:35 -0400 Date: Sat, 30 May 2015 23:56:34 +0200 From: Alexandre Belloni To: Jan Kardell Cc: Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Vincent Donnefort , Dan Carpenter , oen@telliq.com Subject: Re: [PATCH v3] rtc: pcf8563 fix: return -EINVAL if we read an invalid time. Message-ID: <20150530215634.GL2185@piout.net> References: <1432795725-8350-1-git-send-email-jan.kardell@telliq.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432795725-8350-1-git-send-email-jan.kardell@telliq.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/05/2015 at 08:48:45 +0200, Jan Kardell wrote : > Return -EINVAL if the voltage low bit is set to avoid getting a bogus > time at boot. > There was a comment stating that util-linux hwclock refuses to set a > new time if we return an error code on read, but at least the current > version do set the time as expected. Remove the comment and the check > for valid time, and let the rtc core check it for us. > > Changes in v2: Remove the test for invalid time. Change dev_err to > dev_info when voltage low is set. > > Changes in v3: Use dev_err when voltage low is set. > > Signed-off-by: Jan Kardell > --- > drivers/rtc/rtc-pcf8563.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com