From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Arnd Bergmann Subject: Re: [PATCH v2 2/4] devm: fix ioremap_cache() usage Date: Sat, 30 May 2015 22:52:19 +0200 References: <20150530185425.32590.3190.stgit@dwillia2-desk3.amr.corp.intel.com> <20150530185929.32590.22873.stgit@dwillia2-desk3.amr.corp.intel.com> In-Reply-To: <20150530185929.32590.22873.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201505302252.19647.arnd@arndb.de> Sender: owner-linux-mm@kvack.org To: Dan Williams Cc: mingo@redhat.com, bp@alien8.de, hpa@zytor.com, tglx@linutronix.de, ross.zwisler@linux.intel.com, akpm@linux-foundation.org, jgross@suse.com, x86@kernel.org, toshi.kani@hp.com, linux-nvdimm@lists.01.org, mcgrof@suse.com, konrad.wilk@oracle.com, linux-kernel@vger.kernel.org, stefan.bader@canonical.com, luto@amacapital.net, linux-mm@kvack.org, geert@linux-m68k.org, hmh@hmh.eng.br, tj@kernel.org, hch@lst.de List-ID: On Saturday 30 May 2015, Dan Williams wrote: > @@ -154,7 +148,7 @@ void __iomem *devm_ioremap_resource(struct device *dev, struct resource *res) > } > > if (res->flags & IORESOURCE_CACHEABLE) > - dest_ptr = devm_ioremap(dev, res->start, size); > + dest_ptr = devm_ioremap_cache(dev, res->start, size); > else > dest_ptr = devm_ioremap_nocache(dev, res->start, size); I think the existing uses of IORESOURCE_CACHEABLE are mostly bugs, so changing the behavior here may cause more problems than it solves. Arnd -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932362AbbE3UxV (ORCPT ); Sat, 30 May 2015 16:53:21 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:58648 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755868AbbE3UxL (ORCPT ); Sat, 30 May 2015 16:53:11 -0400 From: Arnd Bergmann To: Dan Williams Subject: Re: [PATCH v2 2/4] devm: fix ioremap_cache() usage Date: Sat, 30 May 2015 22:52:19 +0200 User-Agent: KMail/1.12.2 (Linux/3.19.0-13-generic; KDE/4.3.2; x86_64; ; ) Cc: mingo@redhat.com, bp@alien8.de, hpa@zytor.com, tglx@linutronix.de, ross.zwisler@linux.intel.com, akpm@linux-foundation.org, jgross@suse.com, x86@kernel.org, toshi.kani@hp.com, linux-nvdimm@ml01.01.org, mcgrof@suse.com, konrad.wilk@oracle.com, linux-kernel@vger.kernel.org, stefan.bader@canonical.com, luto@amacapital.net, linux-mm@kvack.org, geert@linux-m68k.org, hmh@hmh.eng.br, tj@kernel.org, hch@lst.de References: <20150530185425.32590.3190.stgit@dwillia2-desk3.amr.corp.intel.com> <20150530185929.32590.22873.stgit@dwillia2-desk3.amr.corp.intel.com> In-Reply-To: <20150530185929.32590.22873.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201505302252.19647.arnd@arndb.de> X-Provags-ID: V03:K0:F0H1ZOkwmwWSrKemIdISzoMIdtUIvRtcpZ/qeu4iQJWbUmjXwPJ hxNqB/SG57aRbo+pmIniYF6F5fhRmfOhG3YZ5Wzve/fXWZO6eW66Nt+oeeYa+qSGbCB5qnJ oHtTryn/T0SzI4hlrJk4erLdTXhCN/xDM36pYvYecWtm9toegcY09YVs/O1zF8H/Y9j5DeQ GYz+LuRVIzmXx0cVQPVmA== X-UI-Out-Filterresults: notjunk:1;V01:K0:icZQRaHkbD8=:vzvffLVtvBefkmHLMBuvVv 6ZHH6FeYwof/KiUhoLvxG+p7XlJt5NpkIbxDH/g5PtnJFzWP367zdPiXAtUrYSES+7JlxpOKU DljEYJ9KnRz/lp9ERikyPu1LLFaNEaoVkXvhDvvf6NdskAMHhQyLOu+BUV19dbx+cEGhIwnp1 D1ESwcn0t3h0K7m0q1FUT0ww/gwOBwwceKwGNq5uBHlURqFp8F7kfJppnv82fBnRUsEX1sTLR wlEqp8MaZnYsBldOMx37lvPN7NPzh5c6Wa2Ab11hjtiSztJM2+33oKsxBgfHy7RGa5z08uXFH oH9KIGC8oIRtiRFy88fWFIyN/6fkmsMJNLV1U5X5xCJCPR6NPyeF7yv5HmOwy7LeCK1QIbM+x 47AVlqXOW+gJ4xs3q6IMRJsC7yXwr0fSGbZ8Of8436U9J0eMZdKY8EUhu67o+y8aOtGouUzWu hVJrD44sXI+OZIZGk6aHR3LiV1TaeU7r+4y8ulEw+/wZZv3u0wJTty51LoEVD4MM47Sl8xElK LlA4m08U8KkXzIXBQRmzL73B7FwyuQM4MoHF+YuxX1YcBLQhVXAw9eJFckxgXsJjh7qjN65ag 54R6VJIsB30YTCLeugoftYByTFKcS9nqjkQCuKR5gMaHT9PSYnObSya466+Y0QBAEEcZygFr2 ICLHBHbMfSGR9gXV3IIl6LqrWDZJgPTwTdPv6wrBbe035Yw== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday 30 May 2015, Dan Williams wrote: > @@ -154,7 +148,7 @@ void __iomem *devm_ioremap_resource(struct device *dev, struct resource *res) > } > > if (res->flags & IORESOURCE_CACHEABLE) > - dest_ptr = devm_ioremap(dev, res->start, size); > + dest_ptr = devm_ioremap_cache(dev, res->start, size); > else > dest_ptr = devm_ioremap_nocache(dev, res->start, size); I think the existing uses of IORESOURCE_CACHEABLE are mostly bugs, so changing the behavior here may cause more problems than it solves. Arnd