From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757739AbbEaAmC (ORCPT <rfc822;w@1wt.eu>);
	Sat, 30 May 2015 20:42:02 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:38444 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754038AbbEaAlx (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 30 May 2015 20:41:53 -0400
Date: Sun, 31 May 2015 09:26:35 +0900
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Joe Perches <joe@perches.com>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "mdcasey@chabloom.com" <mdcasey@chabloom.com>,
        "Babu, Viswanathan (V.)" <vbabu3@visteon.com>,
        "lambert.quentin@gmail.com" <lambert.quentin@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "julia.lawall@lip6.fr" <julia.lawall@lip6.fr>,
        "himangi774@gmail.com" <himangi774@gmail.com>,
        "DHANAPAL, GNANACHANDRAN (G.)" <gdhanapa@visteon.com>,
        "kolbeinnkarls@gmail.com" <kolbeinnkarls@gmail.com>
Subject: Re: [PATCH] Staging: rtl8192e: Timer setup using macro rather
 assignment
Message-ID: <20150531002635.GB23738@kroah.com>
References: <20150518144539.GA10481@visteon-gnana>
 <20150518160528.GA2927@sudip-PC>
 <1431966363.2870.24.camel@perches.com>
 <20150518164242.GB12138@sudip-PC>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150518164242.GB12138@sudip-PC>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, May 18, 2015 at 10:12:42PM +0530, Sudip Mukherjee wrote:
> On Mon, May 18, 2015 at 09:26:03AM -0700, Joe Perches wrote:
> > On Mon, 2015-05-18 at 21:35 +0530, Sudip Mukherjee wrote:
> > > On Mon, May 18, 2015 at 02:44:15PM +0000, DHANAPAL, GNANACHANDRAN (G.) wrote:
> > > > setup_timer is used for timer parameter setup rather than direct
> > > > assignment
> > > > 
> > > > Signed-off-by: Gnanachandran Dhanapal <gdhanapa@visteon.com>
> > > 
> > > your From: name and Signed-off-by: names are not matching. They should
> > > be same.
> > 
> > If there's a specific "From: " in the _body_ of the email,
> > that's true, but the sender email "From: " header and the
> > Signed-off-by: line do not have to match.
> But Greg usually rejects these patches where the sender "From:" header
> and Signed-off-by: doesnot match. Just for example:
> 
> https://lkml.org/lkml/2014/11/25/924

Yes, I can't take it where it doesn't match up.

Sometimes I miss it, but when it's pointed out, I will not accept it.

thanks,

greg k-h