From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Nicholas Mc Guire <hofrat@osadl.org>
Cc: Lidza Louina <lidza.louina@gmail.com>,
devel@driverdev.osuosl.org,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: dgnc: use schedule_timeout_interruptible()
Date: Sun, 31 May 2015 10:25:56 +0900 [thread overview]
Message-ID: <20150531012556.GC13096@kroah.com> (raw)
In-Reply-To: <1432917688-20228-1-git-send-email-hofrat@osadl.org>
On Fri, May 29, 2015 at 06:41:27PM +0200, Nicholas Mc Guire wrote:
> API consolidation with coccinelle found:
> ./drivers/staging/dgnc/dgnc_utils.c:16:1-17:
> consolidation with schedule_timeout_*() recommended
>
> This is a 1:1 conversion with respect to schedule_timeout() to the
> schedule_timeout_interruptible() helper only - so only an API
> consolidation to improve readability. The timeout was being passed
> as (ms * HZ) / 1000 but that is not reliable as it allows the timeout
> to become 0 for small values of ms. As this cut-off is HZ dependent
> this is most likely not intended, so the timeout is converted with
> msecs_to_jiffies which handles all corener-cases correctly.
>
> Patch was compile tested with x86_64_defconfig + CONFIG_STAGING=y,
> CONFIG_DGNC=m
>
> Patch is against 4.1-rc5 (localversion-next is -next-20150529)
Can you resend this without these two sentances? They are not needed
and are just "implied" as you should have done this for every patch
submitted.
thanks,
greg k-h
next prev parent reply other threads:[~2015-05-31 1:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 16:41 [PATCH 1/2] staging: dgnc: use schedule_timeout_interruptible() Nicholas Mc Guire
2015-05-29 16:41 ` [PATCH 2/2] staging: dgnc: switch timeout to signed type Nicholas Mc Guire
2015-05-29 17:05 ` Dan Carpenter
2015-05-29 17:21 ` Nicholas Mc Guire
2015-05-29 19:01 ` Dan Carpenter
2015-05-29 19:13 ` Nicholas Mc Guire
2015-05-31 1:25 ` Greg Kroah-Hartman [this message]
2015-05-31 5:54 ` [PATCH 1/2] staging: dgnc: use schedule_timeout_interruptible() Nicholas Mc Guire
2015-05-31 6:39 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150531012556.GC13096@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=hofrat@osadl.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.