From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: David Decotigny <ddecotig@gmail.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org,
Doug Oucharek <doug.s.oucharek@intel.com>,
Peng Tao <bergwolf@gmail.com>, Isaac Huang <he.huang@intel.com>,
Amir Shehata <amir.shehata@intel.com>,
Liang Zhen <liang.zhen@intel.com>
Subject: Re: [PATCH v1] staging: lustre: libcfs: add __user annotation in libcfs_ioctl_data
Date: Sun, 31 May 2015 11:27:44 +0900 [thread overview]
Message-ID: <20150531022744.GA31012@kroah.com> (raw)
In-Reply-To: <1432615204-4062-1-git-send-email-ddecotig@gmail.com>
On Mon, May 25, 2015 at 09:40:04PM -0700, David Decotigny wrote:
> This fixes the following sparse warnings:
> drivers/staging/lustre/lnet/lnet/api-ni.c:1926:38: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/lustre/lnet/lnet/api-ni.c:1926:38: expected void [noderef] <asn:1>*to
> drivers/staging/lustre/lnet/lnet/api-ni.c:1926:38: got struct lnet_process_id_t [usertype] *
> drivers/staging/lustre/lnet/selftest/conctl.c:833:37: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/lustre/lnet/selftest/conctl.c:833:37: expected void const [noderef] <asn:1>*from
> drivers/staging/lustre/lnet/selftest/conctl.c:833:37: got char *ioc_pbuf1
> drivers/staging/lustre/lnet/selftest/conctl.c:918:30: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/lustre/lnet/selftest/conctl.c:918:30: expected void [noderef] <asn:1>*to
> drivers/staging/lustre/lnet/selftest/conctl.c:918:30: got char *ioc_pbuf2
>
> Signed-off-by: David Decotigny <ddecotig@gmail.com>
> ---
> drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h | 4 ++--
> drivers/staging/lustre/include/linux/lnet/lib-lnet.h | 2 +-
> drivers/staging/lustre/lnet/lnet/api-ni.c | 5 +++--
> 3 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h b/drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h
> index 3ee3878..aa687b7 100644
> --- a/drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h
> +++ b/drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h
> @@ -61,9 +61,9 @@ struct libcfs_ioctl_data {
> char *ioc_inlbuf2;
>
> __u32 ioc_plen1; /* buffers in userspace */
> - char *ioc_pbuf1;
> + char __user *ioc_pbuf1;
> __u32 ioc_plen2; /* buffers in userspace */
> - char *ioc_pbuf2;
> + char __user *ioc_pbuf2;
>
> char ioc_bulk[0];
> };
> diff --git a/drivers/staging/lustre/include/linux/lnet/lib-lnet.h b/drivers/staging/lustre/include/linux/lnet/lib-lnet.h
> index 0038d29..7f06b9f7 100644
> --- a/drivers/staging/lustre/include/linux/lnet/lib-lnet.h
> +++ b/drivers/staging/lustre/include/linux/lnet/lib-lnet.h
> @@ -858,7 +858,7 @@ void lnet_swap_pinginfo(lnet_ping_info_t *info);
> int lnet_ping_target_init(void);
> void lnet_ping_target_fini(void);
> int lnet_ping(lnet_process_id_t id, int timeout_ms,
> - lnet_process_id_t *ids, int n_ids);
> + lnet_process_id_t __user *ids, int n_ids);
>
> int lnet_parse_ip2nets(char **networksp, char *ip2nets);
> int lnet_parse_routes(char *route_str, int *im_a_router);
> diff --git a/drivers/staging/lustre/lnet/lnet/api-ni.c b/drivers/staging/lustre/lnet/lnet/api-ni.c
> index 4a14e51..1a0cd57 100644
> --- a/drivers/staging/lustre/lnet/lnet/api-ni.c
> +++ b/drivers/staging/lustre/lnet/lnet/api-ni.c
> @@ -1470,7 +1470,7 @@ LNetCtl(unsigned int cmd, void *arg)
> id.nid = data->ioc_nid;
> id.pid = data->ioc_u32[0];
> rc = lnet_ping(id, data->ioc_u32[1], /* timeout */
> - (lnet_process_id_t *)data->ioc_pbuf1,
> + (lnet_process_id_t __user *)data->ioc_pbuf1,
Why is this marking needed? If so, something must be wrong as isn't
this variable already __user now due to the other part of this patch?
thanks,
greg k-h
next prev parent reply other threads:[~2015-05-31 2:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 4:40 [PATCH v1] staging: lustre: libcfs: add __user annotation in libcfs_ioctl_data David Decotigny
2015-05-31 2:27 ` Greg Kroah-Hartman [this message]
2015-06-01 19:21 ` David Decotigny
2015-06-02 1:31 ` Greg Kroah-Hartman
2015-06-02 17:29 ` [lustre-devel] [HPDD-discuss] " Simmons, James A.
2015-06-02 17:29 ` Simmons, James A.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150531022744.GA31012@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=HPDD-discuss@ml01.01.org \
--cc=amir.shehata@intel.com \
--cc=andreas.dilger@intel.com \
--cc=bergwolf@gmail.com \
--cc=ddecotig@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=doug.s.oucharek@intel.com \
--cc=he.huang@intel.com \
--cc=liang.zhen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.