From: Greg KH <gregkh@linuxfoundation.org>
To: Nikhil Badola <nikhil.badola@freescale.com>
Cc: linux-kernel@vger.kernel.org, stern@rowland.harvard.edu,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/5] drivers:usb:fsl: Check IP version 2.4 for mph USB controller
Date: Sun, 31 May 2015 15:48:59 +0900 [thread overview]
Message-ID: <20150531064859.GA17795@kroah.com> (raw)
In-Reply-To: <1432640682-18555-1-git-send-email-nikhil.badola@freescale.com>
On Tue, May 26, 2015 at 05:14:42PM +0530, Nikhil Badola wrote:
> Check IP version 2.4 for multi port host USB controller and
> return FSL_USB_VER_2_4 macro
>
> Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com>
> ---
> Separate patches clubbed and resent in an ordered patchset
> with proper mailing list in cc
>
> drivers/usb/host/fsl-mph-dr-of.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c
> index 7e325e9..e588ccd 100644
> --- a/drivers/usb/host/fsl-mph-dr-of.c
> +++ b/drivers/usb/host/fsl-mph-dr-of.c
> @@ -126,6 +126,7 @@ static int usb_get_ver_info(struct device_node *np)
> /*
> * returns 1 for usb controller version 1.6
> * returns 2 for usb controller version 2.2
> + * returns 3 for usb controller version 2.4
> * returns 0 otherwise
Shouldn't the comment use the #define names instead of values?
You can do that in a later patch.
thanks,
greg k-h
prev parent reply other threads:[~2015-05-31 6:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 11:44 [PATCH 1/5] drivers:usb:fsl: Check IP version 2.4 for mph USB controller Nikhil Badola
2015-05-31 6:48 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150531064859.GA17795@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nikhil.badola@freescale.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.