From: Andrei Borzenkov <arvidjaar@gmail.com>
To: Paul Menzel <paulepanter@users.sourceforge.net>
Cc: grub-devel@gnu.org
Subject: Re: [PATCH 2/2] disk/ahci.c: Wrap too long line
Date: Sun, 31 May 2015 09:28:21 +0300 [thread overview]
Message-ID: <20150531092821.501b70d0@opensuse.site> (raw)
In-Reply-To: <1432836218.3378.50.camel@users.sourceforge.net>
[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]
Could you merge two patches?
В Thu, 28 May 2015 20:03:38 +0200
Paul Menzel <paulepanter@users.sourceforge.net> пишет:
> Date: Thu, 28 May 2015 19:50:51 +0200
>
> Using the macros the line is too long, so wrap it.
> ---
> grub-core/disk/ahci.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/grub-core/disk/ahci.c b/grub-core/disk/ahci.c
> index 0825998..fa7aa88 100644
> --- a/grub-core/disk/ahci.c
> +++ b/grub-core/disk/ahci.c
> @@ -552,7 +552,9 @@ grub_ahci_pciinit (grub_pci_device_t dev,
> adevs[i]->hba->ports[adevs[i]->port].sata_error);
>
> adevs[i]->hba->ports[adevs[i]->port].command
> - = (adevs[i]->hba->ports[adevs[i]->port].command & 0x0fffffff) | (1 << 28) | GRUB_AHCI_HBA_PORT_CMD_SPIN_UP | GRUB_AHCI_HBA_PORT_CMD_POWER_ON;
> + = (adevs[i]->hba->ports[adevs[i]->port].command & 0x0fffffff) | (1 << 28)
> + | GRUB_AHCI_HBA_PORT_CMD_SPIN_UP
> + | GRUB_AHCI_HBA_PORT_CMD_POWER_ON;
>
> /* struct grub_disk_ata_pass_through_parms parms2;
> grub_memset (&parms2, 0, sizeof (parms2));
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2015-05-31 6:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 17:57 [PATCH 1/2] disk/ahci.c: Use defines `GRUB_AHCI_HBA_PORT_CMD_SPIN_UP` and `GRUB_AHCI_HBA_PORT_CMD_POWER_ON` Paul Menzel
2015-05-28 18:03 ` [PATCH 2/2] disk/ahci.c: Wrap too long line Paul Menzel
2015-05-31 6:28 ` Andrei Borzenkov [this message]
2015-06-07 9:04 ` [PATCH v2] disk/ahci.c: Use defines `GRUB_AHCI_HBA_PORT_CMD_SPIN_UP` and `GRUB_AHCI_HBA_PORT_CMD_POWER_ON` Paul Menzel
2015-06-12 6:44 ` Andrei Borzenkov
2015-06-02 16:43 ` [PATCH 2/2] disk/ahci.c: Wrap too long line Vladimir 'φ-coder/phcoder' Serbinenko
2015-06-02 16:45 ` [PATCH 1/2] disk/ahci.c: Use defines `GRUB_AHCI_HBA_PORT_CMD_SPIN_UP` and `GRUB_AHCI_HBA_PORT_CMD_POWER_ON` Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150531092821.501b70d0@opensuse.site \
--to=arvidjaar@gmail.com \
--cc=grub-devel@gnu.org \
--cc=paulepanter@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.