From: Theodore Ts'o <tytso@mit.edu>
To: Chao Yu <chao2.yu@samsung.com>
Cc: 'Ext4 Developers List' <linux-ext4@vger.kernel.org>,
mhalcrow@google.com, jaegeuk@kernel.org
Subject: Re: [PATCH 2/2] ext4 crypto: fix incorrect release for crypto ctx
Date: Sun, 31 May 2015 13:36:55 -0400 [thread overview]
Message-ID: <20150531173655.GC11642@thunk.org> (raw)
In-Reply-To: <002901d099bb$656709d0$30351d70$@samsung.com>
On Fri, May 29, 2015 at 10:58:09AM +0800, Chao Yu wrote:
> When ext4 encryption feature is enable, and our crypto resource
> was allocated, then if we rmmod ext4 module, we will receive a
> stack backtrace reported in syslog:
>
> The reason is that:
>
> since commit 66de766a0f11
> ("ext4 crypto: shrink size of the ext4_crypto_ctx structure") is merged,
> some fields in ext4_crypto_ctx structure are merged into a union as they
> will never be used simultaneously in write path, read path or on free list.
Thanks for pointing this out; as it turns out "ext4 crypto: shrink
size of the ext4_crypto_ctx structure" hasn't been merged yet (it's
still in the ext4 patch queue and the ext4 dev branch), so I'll just
fix up the commit and update the dev patch.
- Ted
prev parent reply other threads:[~2015-05-31 17:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 2:58 [PATCH 2/2] ext4 crypto: fix incorrect release for crypto ctx Chao Yu
2015-05-31 17:36 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150531173655.GC11642@thunk.org \
--to=tytso@mit.edu \
--cc=chao2.yu@samsung.com \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=mhalcrow@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.