diff for duplicates of <20150601083159.GD3329@x1> diff --git a/a/1.txt b/N1/1.txt index 6d45b37..5f0e6d0 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,10 +2,10 @@ On Sat, 30 May 2015, Vaibhav Hiremath wrote: > From the spec, bit 1 of reg 0xe (page 0): IN_CLEAR_MODE controls the > method of clearing interrupt status register of 88pm800; ->=20 +> > 0: clear on read > 1: clear on write ->=20 +> > Signed-off-by: zhaoy <zhaoy@marvell.com> This signed-off is not acceptable. @@ -17,40 +17,39 @@ No nicknames. Full names only. > drivers/mfd/88pm800.c | 4 +++- > include/linux/mfd/88pm80x.h | 2 ++ > 2 files changed, 5 insertions(+), 1 deletion(-) ->=20 +> > diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c > index 06ee058..8ea4467 100644 > --- a/drivers/mfd/88pm800.c > +++ b/drivers/mfd/88pm800.c -> @@ -391,7 +391,8 @@ static int device_irq_init_800(struct pm80x_chip *chi= -p) +> @@ -391,7 +391,8 @@ static int device_irq_init_800(struct pm80x_chip *chip) > PM800_WAKEUP2_INV_INT | PM800_WAKEUP2_INT_CLEAR | > PM800_WAKEUP2_INT_MASK; -> =20 -> - data =3D PM800_WAKEUP2_INT_CLEAR; -> + data =3D (chip->irq_mode) ? +> +> - data = PM800_WAKEUP2_INT_CLEAR; +> + data = (chip->irq_mode) ? > + PM800_WAKEUP2_INT_WRITE_CLEAR : PM800_WAKEUP2_INT_READ_CLEAR; These variable names are terrible. 'irq_mode' as a bool tells me nothing. -What does; irq_mode =3D 'yes' and irq_mode =3D 'no' mean? If I didn't +What does; irq_mode = 'yes' and irq_mode = 'no' mean? If I didn't read the remainder of the code, I would assume if it was 'yes' then the device was in IRQ Mode and if not, it would be in PIO or Polling mode, but that's not what it means at all is it? As for 'data', well, isn't everything data? -> ret =3D regmap_update_bits(map, PM800_WAKEUP2, mask, data); -> =20 +> ret = regmap_update_bits(map, PM800_WAKEUP2, mask, data); +> > if (ret < 0) > @@ -514,6 +515,7 @@ static int device_800_init(struct pm80x_chip *chip, > } -> =20 -> chip->regmap_irq_chip =3D &pm800_irq_chip; -> + chip->irq_mode =3D pdata->irq_mode; -> =20 -> ret =3D device_irq_init_800(chip); +> +> chip->regmap_irq_chip = &pm800_irq_chip; +> + chip->irq_mode = pdata->irq_mode; +> +> ret = device_irq_init_800(chip); > if (ret < 0) { > diff --git a/include/linux/mfd/88pm80x.h b/include/linux/mfd/88pm80x.h > index 97cb283..6ed6c16 100644 @@ -63,24 +62,11 @@ As for 'data', well, isn't everything data? > +#define PM800_WAKEUP2_INT_READ_CLEAR (0 << 1) > +#define PM800_WAKEUP2_INT_WRITE_CLEAR (1 << 1) > #define PM800_WAKEUP2_INT_MASK (1 << 2) -> =20 +> > #define PM800_POWER_UP_LOG (0x10) ---=20 +-- Lee Jones Linaro STMicroelectronics Landing Team Lead -Linaro.org =E2=94=82 Open source software for ARM SoCs +Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog - ---=20 ---=20 -You received this message because you are subscribed to "rtc-linux". -Membership options at http://groups.google.com/group/rtc-linux . -Please read http://groups.google.com/group/rtc-linux/web/checklist -before submitting a driver. ----=20 -You received this message because you are subscribed to the Google Groups "= -rtc-linux" group. -To unsubscribe from this group and stop receiving emails from it, send an e= -mail to rtc-linux+unsubscribe@googlegroups.com. -For more options, visit https://groups.google.com/d/optout. diff --git a/a/content_digest b/N1/content_digest index 210fb9b..72e0785 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,28 +1,19 @@ "ref\01432937962-4537-1-git-send-email-vaibhav.hiremath@linaro.org\0" "ref\01432937962-4537-3-git-send-email-vaibhav.hiremath@linaro.org\0" - "From\0Lee Jones <lee.jones@linaro.org>\0" - "Subject\0[rtc-linux] Re: [PATCH 2/4] mfd: 88pm800: use irq_mode to configure interrupt status reg clear method\0" + "From\0lee.jones@linaro.org (Lee Jones)\0" + "Subject\0[PATCH 2/4] mfd: 88pm800: use irq_mode to configure interrupt status reg clear method\0" "Date\0Mon, 1 Jun 2015 09:31:59 +0100\0" - "To\0Vaibhav Hiremath <vaibhav.hiremath@linaro.org>\0" - "Cc\0linux-arm-kernel@lists.infradead.org" - robh+dt@kernel.org - devicetree@vger.kernel.org - linux-kernel@vger.kernel.org - rtc-linux@googlegroups.com - sameo@linux.intel.com - a.zummo@towertech.it - alexandre.belloni@free-electrons.com - " zhaoy <zhaoy@marvell.com>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Sat, 30 May 2015, Vaibhav Hiremath wrote:\n" "\n" "> From the spec, bit 1 of reg 0xe (page 0): IN_CLEAR_MODE controls the\n" "> method of clearing interrupt status register of 88pm800;\n" - ">=20\n" + "> \n" "> 0: clear on read\n" "> 1: clear on write\n" - ">=20\n" + "> \n" "> Signed-off-by: zhaoy <zhaoy@marvell.com>\n" "\n" "This signed-off is not acceptable.\n" @@ -34,40 +25,39 @@ "> drivers/mfd/88pm800.c | 4 +++-\n" "> include/linux/mfd/88pm80x.h | 2 ++\n" "> 2 files changed, 5 insertions(+), 1 deletion(-)\n" - ">=20\n" + "> \n" "> diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c\n" "> index 06ee058..8ea4467 100644\n" "> --- a/drivers/mfd/88pm800.c\n" "> +++ b/drivers/mfd/88pm800.c\n" - "> @@ -391,7 +391,8 @@ static int device_irq_init_800(struct pm80x_chip *chi=\n" - "p)\n" + "> @@ -391,7 +391,8 @@ static int device_irq_init_800(struct pm80x_chip *chip)\n" "> \t PM800_WAKEUP2_INV_INT | PM800_WAKEUP2_INT_CLEAR |\n" "> \t PM800_WAKEUP2_INT_MASK;\n" - "> =20\n" - "> -\tdata =3D PM800_WAKEUP2_INT_CLEAR;\n" - "> +\tdata =3D (chip->irq_mode) ?\n" + "> \n" + "> -\tdata = PM800_WAKEUP2_INT_CLEAR;\n" + "> +\tdata = (chip->irq_mode) ?\n" "> +\t\tPM800_WAKEUP2_INT_WRITE_CLEAR : PM800_WAKEUP2_INT_READ_CLEAR;\n" "\n" "These variable names are terrible. 'irq_mode' as a bool tells me\n" "nothing.\n" "\n" - "What does; irq_mode =3D 'yes' and irq_mode =3D 'no' mean? If I didn't\n" + "What does; irq_mode = 'yes' and irq_mode = 'no' mean? If I didn't\n" "read the remainder of the code, I would assume if it was 'yes' then\n" "the device was in IRQ Mode and if not, it would be in PIO or Polling\n" "mode, but that's not what it means at all is it?\n" "\n" "As for 'data', well, isn't everything data?\n" "\n" - "> \tret =3D regmap_update_bits(map, PM800_WAKEUP2, mask, data);\n" - "> =20\n" + "> \tret = regmap_update_bits(map, PM800_WAKEUP2, mask, data);\n" + "> \n" "> \tif (ret < 0)\n" "> @@ -514,6 +515,7 @@ static int device_800_init(struct pm80x_chip *chip,\n" "> \t}\n" - "> =20\n" - "> \tchip->regmap_irq_chip =3D &pm800_irq_chip;\n" - "> +\tchip->irq_mode =3D pdata->irq_mode;\n" - "> =20\n" - "> \tret =3D device_irq_init_800(chip);\n" + "> \n" + "> \tchip->regmap_irq_chip = &pm800_irq_chip;\n" + "> +\tchip->irq_mode = pdata->irq_mode;\n" + "> \n" + "> \tret = device_irq_init_800(chip);\n" "> \tif (ret < 0) {\n" "> diff --git a/include/linux/mfd/88pm80x.h b/include/linux/mfd/88pm80x.h\n" "> index 97cb283..6ed6c16 100644\n" @@ -80,26 +70,13 @@ "> +#define PM800_WAKEUP2_INT_READ_CLEAR\t\t(0 << 1)\n" "> +#define PM800_WAKEUP2_INT_WRITE_CLEAR\t\t(1 << 1)\n" "> #define PM800_WAKEUP2_INT_MASK\t\t(1 << 2)\n" - "> =20\n" + "> \n" "> #define PM800_POWER_UP_LOG\t(0x10)\n" "\n" - "--=20\n" + "-- \n" "Lee Jones\n" "Linaro STMicroelectronics Landing Team Lead\n" - "Linaro.org =E2=94=82 Open source software for ARM SoCs\n" - "Follow Linaro: Facebook | Twitter | Blog\n" - "\n" - "--=20\n" - "--=20\n" - "You received this message because you are subscribed to \"rtc-linux\".\n" - "Membership options at http://groups.google.com/group/rtc-linux .\n" - "Please read http://groups.google.com/group/rtc-linux/web/checklist\n" - "before submitting a driver.\n" - "---=20\n" - "You received this message because you are subscribed to the Google Groups \"=\n" - "rtc-linux\" group.\n" - "To unsubscribe from this group and stop receiving emails from it, send an e=\n" - "mail to rtc-linux+unsubscribe@googlegroups.com.\n" - For more options, visit https://groups.google.com/d/optout. + "Linaro.org ? Open source software for ARM SoCs\n" + Follow Linaro: Facebook | Twitter | Blog -7c60d962c88141ce28ad1f245ae0dba4a5c468de64b298b9ef8c33921833bba0 +35e8fbd4c59a025c9b7ab711259f6fdc3bde0875b446f89724f4988ea768669b
diff --git a/a/1.txt b/N2/1.txt index 6d45b37..3c45d0e 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -2,10 +2,10 @@ On Sat, 30 May 2015, Vaibhav Hiremath wrote: > From the spec, bit 1 of reg 0xe (page 0): IN_CLEAR_MODE controls the > method of clearing interrupt status register of 88pm800; ->=20 +> > 0: clear on read > 1: clear on write ->=20 +> > Signed-off-by: zhaoy <zhaoy@marvell.com> This signed-off is not acceptable. @@ -17,40 +17,39 @@ No nicknames. Full names only. > drivers/mfd/88pm800.c | 4 +++- > include/linux/mfd/88pm80x.h | 2 ++ > 2 files changed, 5 insertions(+), 1 deletion(-) ->=20 +> > diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c > index 06ee058..8ea4467 100644 > --- a/drivers/mfd/88pm800.c > +++ b/drivers/mfd/88pm800.c -> @@ -391,7 +391,8 @@ static int device_irq_init_800(struct pm80x_chip *chi= -p) +> @@ -391,7 +391,8 @@ static int device_irq_init_800(struct pm80x_chip *chip) > PM800_WAKEUP2_INV_INT | PM800_WAKEUP2_INT_CLEAR | > PM800_WAKEUP2_INT_MASK; -> =20 -> - data =3D PM800_WAKEUP2_INT_CLEAR; -> + data =3D (chip->irq_mode) ? +> +> - data = PM800_WAKEUP2_INT_CLEAR; +> + data = (chip->irq_mode) ? > + PM800_WAKEUP2_INT_WRITE_CLEAR : PM800_WAKEUP2_INT_READ_CLEAR; These variable names are terrible. 'irq_mode' as a bool tells me nothing. -What does; irq_mode =3D 'yes' and irq_mode =3D 'no' mean? If I didn't +What does; irq_mode = 'yes' and irq_mode = 'no' mean? If I didn't read the remainder of the code, I would assume if it was 'yes' then the device was in IRQ Mode and if not, it would be in PIO or Polling mode, but that's not what it means at all is it? As for 'data', well, isn't everything data? -> ret =3D regmap_update_bits(map, PM800_WAKEUP2, mask, data); -> =20 +> ret = regmap_update_bits(map, PM800_WAKEUP2, mask, data); +> > if (ret < 0) > @@ -514,6 +515,7 @@ static int device_800_init(struct pm80x_chip *chip, > } -> =20 -> chip->regmap_irq_chip =3D &pm800_irq_chip; -> + chip->irq_mode =3D pdata->irq_mode; -> =20 -> ret =3D device_irq_init_800(chip); +> +> chip->regmap_irq_chip = &pm800_irq_chip; +> + chip->irq_mode = pdata->irq_mode; +> +> ret = device_irq_init_800(chip); > if (ret < 0) { > diff --git a/include/linux/mfd/88pm80x.h b/include/linux/mfd/88pm80x.h > index 97cb283..6ed6c16 100644 @@ -63,24 +62,11 @@ As for 'data', well, isn't everything data? > +#define PM800_WAKEUP2_INT_READ_CLEAR (0 << 1) > +#define PM800_WAKEUP2_INT_WRITE_CLEAR (1 << 1) > #define PM800_WAKEUP2_INT_MASK (1 << 2) -> =20 +> > #define PM800_POWER_UP_LOG (0x10) ---=20 +-- Lee Jones Linaro STMicroelectronics Landing Team Lead -Linaro.org =E2=94=82 Open source software for ARM SoCs +Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog - ---=20 ---=20 -You received this message because you are subscribed to "rtc-linux". -Membership options at http://groups.google.com/group/rtc-linux . -Please read http://groups.google.com/group/rtc-linux/web/checklist -before submitting a driver. ----=20 -You received this message because you are subscribed to the Google Groups "= -rtc-linux" group. -To unsubscribe from this group and stop receiving emails from it, send an e= -mail to rtc-linux+unsubscribe@googlegroups.com. -For more options, visit https://groups.google.com/d/optout. diff --git a/a/content_digest b/N2/content_digest index 210fb9b..c62b8a7 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,7 +1,7 @@ "ref\01432937962-4537-1-git-send-email-vaibhav.hiremath@linaro.org\0" "ref\01432937962-4537-3-git-send-email-vaibhav.hiremath@linaro.org\0" "From\0Lee Jones <lee.jones@linaro.org>\0" - "Subject\0[rtc-linux] Re: [PATCH 2/4] mfd: 88pm800: use irq_mode to configure interrupt status reg clear method\0" + "Subject\0Re: [PATCH 2/4] mfd: 88pm800: use irq_mode to configure interrupt status reg clear method\0" "Date\0Mon, 1 Jun 2015 09:31:59 +0100\0" "To\0Vaibhav Hiremath <vaibhav.hiremath@linaro.org>\0" "Cc\0linux-arm-kernel@lists.infradead.org" @@ -19,10 +19,10 @@ "\n" "> From the spec, bit 1 of reg 0xe (page 0): IN_CLEAR_MODE controls the\n" "> method of clearing interrupt status register of 88pm800;\n" - ">=20\n" + "> \n" "> 0: clear on read\n" "> 1: clear on write\n" - ">=20\n" + "> \n" "> Signed-off-by: zhaoy <zhaoy@marvell.com>\n" "\n" "This signed-off is not acceptable.\n" @@ -34,40 +34,39 @@ "> drivers/mfd/88pm800.c | 4 +++-\n" "> include/linux/mfd/88pm80x.h | 2 ++\n" "> 2 files changed, 5 insertions(+), 1 deletion(-)\n" - ">=20\n" + "> \n" "> diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c\n" "> index 06ee058..8ea4467 100644\n" "> --- a/drivers/mfd/88pm800.c\n" "> +++ b/drivers/mfd/88pm800.c\n" - "> @@ -391,7 +391,8 @@ static int device_irq_init_800(struct pm80x_chip *chi=\n" - "p)\n" + "> @@ -391,7 +391,8 @@ static int device_irq_init_800(struct pm80x_chip *chip)\n" "> \t PM800_WAKEUP2_INV_INT | PM800_WAKEUP2_INT_CLEAR |\n" "> \t PM800_WAKEUP2_INT_MASK;\n" - "> =20\n" - "> -\tdata =3D PM800_WAKEUP2_INT_CLEAR;\n" - "> +\tdata =3D (chip->irq_mode) ?\n" + "> \n" + "> -\tdata = PM800_WAKEUP2_INT_CLEAR;\n" + "> +\tdata = (chip->irq_mode) ?\n" "> +\t\tPM800_WAKEUP2_INT_WRITE_CLEAR : PM800_WAKEUP2_INT_READ_CLEAR;\n" "\n" "These variable names are terrible. 'irq_mode' as a bool tells me\n" "nothing.\n" "\n" - "What does; irq_mode =3D 'yes' and irq_mode =3D 'no' mean? If I didn't\n" + "What does; irq_mode = 'yes' and irq_mode = 'no' mean? If I didn't\n" "read the remainder of the code, I would assume if it was 'yes' then\n" "the device was in IRQ Mode and if not, it would be in PIO or Polling\n" "mode, but that's not what it means at all is it?\n" "\n" "As for 'data', well, isn't everything data?\n" "\n" - "> \tret =3D regmap_update_bits(map, PM800_WAKEUP2, mask, data);\n" - "> =20\n" + "> \tret = regmap_update_bits(map, PM800_WAKEUP2, mask, data);\n" + "> \n" "> \tif (ret < 0)\n" "> @@ -514,6 +515,7 @@ static int device_800_init(struct pm80x_chip *chip,\n" "> \t}\n" - "> =20\n" - "> \tchip->regmap_irq_chip =3D &pm800_irq_chip;\n" - "> +\tchip->irq_mode =3D pdata->irq_mode;\n" - "> =20\n" - "> \tret =3D device_irq_init_800(chip);\n" + "> \n" + "> \tchip->regmap_irq_chip = &pm800_irq_chip;\n" + "> +\tchip->irq_mode = pdata->irq_mode;\n" + "> \n" + "> \tret = device_irq_init_800(chip);\n" "> \tif (ret < 0) {\n" "> diff --git a/include/linux/mfd/88pm80x.h b/include/linux/mfd/88pm80x.h\n" "> index 97cb283..6ed6c16 100644\n" @@ -80,26 +79,13 @@ "> +#define PM800_WAKEUP2_INT_READ_CLEAR\t\t(0 << 1)\n" "> +#define PM800_WAKEUP2_INT_WRITE_CLEAR\t\t(1 << 1)\n" "> #define PM800_WAKEUP2_INT_MASK\t\t(1 << 2)\n" - "> =20\n" + "> \n" "> #define PM800_POWER_UP_LOG\t(0x10)\n" "\n" - "--=20\n" + "-- \n" "Lee Jones\n" "Linaro STMicroelectronics Landing Team Lead\n" - "Linaro.org =E2=94=82 Open source software for ARM SoCs\n" - "Follow Linaro: Facebook | Twitter | Blog\n" - "\n" - "--=20\n" - "--=20\n" - "You received this message because you are subscribed to \"rtc-linux\".\n" - "Membership options at http://groups.google.com/group/rtc-linux .\n" - "Please read http://groups.google.com/group/rtc-linux/web/checklist\n" - "before submitting a driver.\n" - "---=20\n" - "You received this message because you are subscribed to the Google Groups \"=\n" - "rtc-linux\" group.\n" - "To unsubscribe from this group and stop receiving emails from it, send an e=\n" - "mail to rtc-linux+unsubscribe@googlegroups.com.\n" - For more options, visit https://groups.google.com/d/optout. + "Linaro.org \342\224\202 Open source software for ARM SoCs\n" + Follow Linaro: Facebook | Twitter | Blog -7c60d962c88141ce28ad1f245ae0dba4a5c468de64b298b9ef8c33921833bba0 +0237bd5428af94c07605453d477e3847385404e83dcb3abccb5784a7e4cc4c17
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.