From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH 2/9] mm: Provide new get_vaddr_frames() helper Date: Mon, 1 Jun 2015 14:40:17 +0200 Message-ID: <20150601124017.GC20288@quack.suse.cz> References: <1431522495-4692-1-git-send-email-jack@suse.cz> <1431522495-4692-3-git-send-email-jack@suse.cz> <20150528162402.19a0a26a5b9eae36aa8050e5@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20150528162402.19a0a26a5b9eae36aa8050e5@linux-foundation.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Andrew Morton Cc: linux-samsung-soc@vger.kernel.org, Jan Kara , Pawel Osciak , Mauro Carvalho Chehab , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, mgorman@suse.de, Marek Szyprowski , linux-media@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org T24gVGh1IDI4LTA1LTE1IDE2OjI0OjAyLCBBbmRyZXcgTW9ydG9uIHdyb3RlOgo+IE9uIFdlZCwg MTMgTWF5IDIwMTUgMTU6MDg6MDggKzAyMDAgSmFuIEthcmEgPGphY2tAc3VzZS5jej4gd3JvdGU6 Cj4gCj4gPiBQcm92aWRlIG5ldyBmdW5jdGlvbiBnZXRfdmFkZHJfZnJhbWVzKCkuICBUaGlzIGZ1 bmN0aW9uIG1hcHMgdmlydHVhbAo+ID4gYWRkcmVzc2VzIGZyb20gZ2l2ZW4gc3RhcnQgYW5kIGZp bGxzIGdpdmVuIGFycmF5IHdpdGggcGFnZSBmcmFtZSBudW1iZXJzIG9mCj4gPiB0aGUgY29ycmVz cG9uZGluZyBwYWdlcy4gSWYgZ2l2ZW4gc3RhcnQgYmVsb25ncyB0byBhIG5vcm1hbCB2bWEsIHRo ZSBmdW5jdGlvbgo+ID4gZ3JhYnMgcmVmZXJlbmNlIHRvIGVhY2ggb2YgdGhlIHBhZ2VzIHRvIHBp biB0aGVtIGluIG1lbW9yeS4gSWYgc3RhcnQKPiA+IGJlbG9uZ3MgdG8gVk1fSU8gfCBWTV9QRk5N QVAgdm1hLCB3ZSBkb24ndCB0b3VjaCBwYWdlIHN0cnVjdHVyZXMuIENhbGxlcgo+ID4gbXVzdCBt YWtlIHN1cmUgcGZucyBhcmVuJ3QgcmV1c2VkIGZvciBhbnl0aGluZyBlbHNlIHdoaWxlIGhlIGlz IHVzaW5nCj4gPiB0aGVtLgo+ID4gCj4gPiBUaGlzIGZ1bmN0aW9uIGlzIGNyZWF0ZWQgZm9yIHZh cmlvdXMgZHJpdmVycyB0byBzaW1wbGlmeSBoYW5kbGluZyBvZgo+ID4gdGhlaXIgYnVmZmVycy4K PiA+IAo+ID4gQWNrZWQtYnk6IE1lbCBHb3JtYW4gPG1nb3JtYW5Ac3VzZS5kZT4KPiA+IEFja2Vk LWJ5OiBWbGFzdGltaWwgQmFia2EgPHZiYWJrYUBzdXNlLmN6Pgo+ID4gU2lnbmVkLW9mZi1ieTog SmFuIEthcmEgPGphY2tAc3VzZS5jej4KPiA+IC0tLQo+ID4gIGluY2x1ZGUvbGludXgvbW0uaCB8 ICA0NCArKysrKysrKysrKwo+ID4gIG1tL2d1cC5jICAgICAgICAgICB8IDIyNiArKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+IAo+IFRoYXQncyBh IGx1bXAgb2YgbmV3IGNvZGUgd2hpY2ggbWFueSBrZXJuZWxzIHdvbid0IGJlIG5lZWRpbmcuICBD YW4gd2UKPiBwdXQgYWxsIHRoaXMgaW4gYSBuZXcgLmMgZmlsZSBhbmQgc2VsZWN0IGl0IHdpdGhp biBkcml2ZXJzL21lZGlhCj4gS2NvbmZpZz8KICBZZWFoLCBtYWtlcyBzZW5zZS4gSSdsbCB3cml0 ZSBhIHBhdGNoLiBIYW5zLCBpcyBpdCBPSyB3aXRoIHlvdSBpZiBJCmp1c3QgY3JlYXRlIGEgcGF0 Y2ggb24gdG9wIG9mIHRoZSBzZXJpZXMgeW91IGhhdmUgaW4geW91ciB0cmVlPwoKCQkJCQkJCQlI b256YQotLSAKSmFuIEthcmEgPGphY2tAc3VzZS5jej4KU1VTRSBMYWJzLCBDUgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from cantor2.suse.de ([195.135.220.15]:47127 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751507AbbFAMkW (ORCPT ); Mon, 1 Jun 2015 08:40:22 -0400 Date: Mon, 1 Jun 2015 14:40:17 +0200 From: Jan Kara To: Andrew Morton Cc: Jan Kara , linux-mm@kvack.org, linux-media@vger.kernel.org, Hans Verkuil , dri-devel@lists.freedesktop.org, Pawel Osciak , Mauro Carvalho Chehab , mgorman@suse.de, Marek Szyprowski , linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH 2/9] mm: Provide new get_vaddr_frames() helper Message-ID: <20150601124017.GC20288@quack.suse.cz> References: <1431522495-4692-1-git-send-email-jack@suse.cz> <1431522495-4692-3-git-send-email-jack@suse.cz> <20150528162402.19a0a26a5b9eae36aa8050e5@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150528162402.19a0a26a5b9eae36aa8050e5@linux-foundation.org> Sender: linux-media-owner@vger.kernel.org List-ID: On Thu 28-05-15 16:24:02, Andrew Morton wrote: > On Wed, 13 May 2015 15:08:08 +0200 Jan Kara wrote: > > > Provide new function get_vaddr_frames(). This function maps virtual > > addresses from given start and fills given array with page frame numbers of > > the corresponding pages. If given start belongs to a normal vma, the function > > grabs reference to each of the pages to pin them in memory. If start > > belongs to VM_IO | VM_PFNMAP vma, we don't touch page structures. Caller > > must make sure pfns aren't reused for anything else while he is using > > them. > > > > This function is created for various drivers to simplify handling of > > their buffers. > > > > Acked-by: Mel Gorman > > Acked-by: Vlastimil Babka > > Signed-off-by: Jan Kara > > --- > > include/linux/mm.h | 44 +++++++++++ > > mm/gup.c | 226 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > > That's a lump of new code which many kernels won't be needing. Can we > put all this in a new .c file and select it within drivers/media > Kconfig? Yeah, makes sense. I'll write a patch. Hans, is it OK with you if I just create a patch on top of the series you have in your tree? Honza -- Jan Kara SUSE Labs, CR From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) by kanga.kvack.org (Postfix) with ESMTP id EFEBC6B0038 for ; Mon, 1 Jun 2015 08:40:22 -0400 (EDT) Received: by wgbgq6 with SMTP id gq6so113242784wgb.3 for ; Mon, 01 Jun 2015 05:40:22 -0700 (PDT) Received: from mx2.suse.de (cantor2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id fa5si24580196wjd.72.2015.06.01.05.40.21 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 01 Jun 2015 05:40:21 -0700 (PDT) Date: Mon, 1 Jun 2015 14:40:17 +0200 From: Jan Kara Subject: Re: [PATCH 2/9] mm: Provide new get_vaddr_frames() helper Message-ID: <20150601124017.GC20288@quack.suse.cz> References: <1431522495-4692-1-git-send-email-jack@suse.cz> <1431522495-4692-3-git-send-email-jack@suse.cz> <20150528162402.19a0a26a5b9eae36aa8050e5@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150528162402.19a0a26a5b9eae36aa8050e5@linux-foundation.org> Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Jan Kara , linux-mm@kvack.org, linux-media@vger.kernel.org, Hans Verkuil , dri-devel@lists.freedesktop.org, Pawel Osciak , Mauro Carvalho Chehab , mgorman@suse.de, Marek Szyprowski , linux-samsung-soc@vger.kernel.org On Thu 28-05-15 16:24:02, Andrew Morton wrote: > On Wed, 13 May 2015 15:08:08 +0200 Jan Kara wrote: > > > Provide new function get_vaddr_frames(). This function maps virtual > > addresses from given start and fills given array with page frame numbers of > > the corresponding pages. If given start belongs to a normal vma, the function > > grabs reference to each of the pages to pin them in memory. If start > > belongs to VM_IO | VM_PFNMAP vma, we don't touch page structures. Caller > > must make sure pfns aren't reused for anything else while he is using > > them. > > > > This function is created for various drivers to simplify handling of > > their buffers. > > > > Acked-by: Mel Gorman > > Acked-by: Vlastimil Babka > > Signed-off-by: Jan Kara > > --- > > include/linux/mm.h | 44 +++++++++++ > > mm/gup.c | 226 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > > That's a lump of new code which many kernels won't be needing. Can we > put all this in a new .c file and select it within drivers/media > Kconfig? Yeah, makes sense. I'll write a patch. Hans, is it OK with you if I just create a patch on top of the series you have in your tree? Honza -- Jan Kara SUSE Labs, CR -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org