From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, linux-kernel@vger.kernel.org,
namhyung@kernel.org, eranian@google.com,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 04/10] perf, tools, report: Add processing for cycle histograms
Date: Mon, 1 Jun 2015 15:02:23 +0200 [thread overview]
Message-ID: <20150601130223.GA9846@krava.redhat.com> (raw)
In-Reply-To: <20150526173730.GP19417@two.firstfloor.org>
On Tue, May 26, 2015 at 07:37:30PM +0200, Andi Kleen wrote:
> > hum, so this is assuming that having cycles fort 1st entry
> > means there'll be for the rest?
> > Also in that case why is there the '!= cycles' check within
> > addr_map_symbol__account_cycles ?
> >
> It means there might be. It's just a short cut. But rarely
> branches may still have 0 cycles, so it still needs to be
> checked later.
>
> In theory it could miss a valid one if the first happened
> to be zero, but that seems very unlikely.
so having 'bs->entries[0].flags.cycles' is the only way
of knowing that we have the feature enabled?
jirka
next prev parent reply other threads:[~2015-06-01 13:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-10 13:51 Cycles annotation support for perf tools Andi Kleen
2015-05-10 13:51 ` [PATCH 01/10] perf, tools: Add tools support for cycles, weight branch_info field Andi Kleen
2015-05-10 13:51 ` [PATCH 02/10] perf, tools, report: Add flag for non ANY branch mode Andi Kleen
2015-05-10 13:51 ` [PATCH 03/10] perf, tools, report: Add infrastructure for a cycles histogram Andi Kleen
2015-05-10 13:52 ` [PATCH 04/10] perf, tools, report: Add processing for cycle histograms Andi Kleen
2015-05-26 10:09 ` Jiri Olsa
2015-05-26 17:37 ` Andi Kleen
2015-06-01 13:02 ` Jiri Olsa [this message]
2015-06-01 13:07 ` Andi Kleen
2015-05-10 13:52 ` [PATCH 05/10] perf, tools: Compute IPC and basic block cycles for annotate Andi Kleen
2015-05-10 13:52 ` [PATCH 06/10] perf, tools, annotate: Finally display IPC and cycle accounting Andi Kleen
2015-05-10 13:52 ` [PATCH 07/10] perf, tools, report: Move branch option parsing to own file Andi Kleen
2015-05-26 10:09 ` Jiri Olsa
2015-05-10 13:52 ` [PATCH 08/10] perf, tools, top: Add branch annotation code to top Andi Kleen
2015-05-10 13:52 ` [PATCH 09/10] perf, tools, report: Display cycles in branch sort mode Andi Kleen
2015-05-10 13:52 ` [PATCH 10/10] test patch: Add fake branch cycles to input data in report/top Andi Kleen
2015-05-18 19:06 ` Cycles annotation support for perf tools Andi Kleen
2015-05-19 9:55 ` Jiri Olsa
2015-05-24 18:55 ` Jiri Olsa
2015-05-24 19:19 ` Andi Kleen
2015-05-26 10:08 ` Jiri Olsa
2015-05-26 16:56 ` Andi Kleen
2015-05-26 21:40 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150601130223.GA9846@krava.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.